Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nested_join) incorrect result of semi/anti mark join #24616

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[fix](nested_join) incorrect result of semi/anti mark join #24616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/vec/exec/join/vnested_loop_join_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ void VNestedLoopJoinNode::_finalize_current_phase(MutableBlock& mutable_block, s
DCHECK_LE(_left_block_start_pos + _left_side_process_count, _left_block.rows());
for (int j = _left_block_start_pos;
j < _left_block_start_pos + _left_side_process_count; ++j) {
mark_data.emplace_back(IsSemi != _cur_probe_row_visited_flags[j]);
mark_data.emplace_back(IsSemi == _cur_probe_row_visited_flags[j]);
}
for (size_t i = 0; i < _num_probe_side_columns; ++i) {
const ColumnWithTypeAndName src_column = _left_block.get_by_position(i);
Expand Down
8 changes: 0 additions & 8 deletions regression-test/data/nereids_syntax_p0/sub_query_correlated.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,15 +406,7 @@
2 5
3 3
3 4

-- !doris_6937_2 --
1 2
1 3
2 4
2 5
20 2
22 3
24 4
3 3
3 4

6 changes: 3 additions & 3 deletions regression-test/suites/nereids_syntax_p0/sub_query_correlated.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,17 +452,17 @@ suite ("sub_query_correlated") {
OR exists (SELECT * FROM sub_query_correlated_subquery3, sub_query_correlated_subquery5 WHERE sub_query_correlated_subquery1.k2 = sub_query_correlated_subquery3.v1 and sub_query_correlated_subquery3.v1 = sub_query_correlated_subquery5.k1))
"""

order_qt_doris_6937 """
qt_doris_6937 """
SELECT *
FROM sub_query_correlated_subquery1
WHERE EXISTS
(SELECT k1
FROM sub_query_correlated_subquery3
WHERE sub_query_correlated_subquery1.k1 > sub_query_correlated_subquery3.v1)
OR k1 < 10;
OR k1 < 10
order by k1, k2;
"""

// uncomment this after DORIS-7051 is fixed
// order_qt_doris_6937_2 """
// select * from sub_query_correlated_subquery1 where sub_query_correlated_subquery1.k1 not in (select sub_query_correlated_subquery3.k3 from sub_query_correlated_subquery3 where sub_query_correlated_subquery3.v2 > sub_query_correlated_subquery1.k2) or k1 < 10 order by k1, k2;
// """
Expand Down