Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift codegen: Add operation name to generated operation #1163

Closed
wants to merge 1 commit into from

Conversation

js
Copy link

@js js commented Apr 2, 2019

This adds operationName to the generated swift declarations.

It goes together with this PR in apollo-ios, but should not be dependent on each other

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@js
Copy link
Author

js commented Apr 2, 2019

Not a JS dev so not quite clear to me why some of the tests are failing in CI? Locally npm test only gives me an error for the Git integration › Returns commit, branch, message, committer, and remoteUrl test, since I have a different remote

@js js force-pushed the swift-operation-name branch from 027edfb to 843026b Compare April 5, 2019 07:20
@js
Copy link
Author

js commented Apr 5, 2019

The failing apollo-tooling test says Type check failed. Run 'npm run client:codegen' in the output, but seems I need an API key to do that (when I run it locally): { Error: Error in "Loading schema for engine": Error: ENGINE_API_KEY not found

Really want to get this change in :)

@js js force-pushed the swift-operation-name branch from 843026b to a1c6ba5 Compare April 10, 2019 08:39
@js
Copy link
Author

js commented Apr 10, 2019

Rebased against master, still seem to get test failures in CI (but not locally) on unrelated things. Are the tests expected to be flaky?

@js js force-pushed the swift-operation-name branch from a1c6ba5 to c1818d1 Compare May 13, 2019 07:59
@trevor-scheer trevor-scheer requested review from designatednerd and removed request for jbaxleyiii and trevor-scheer July 12, 2019 18:40
@trevor-scheer trevor-scheer added 🐦 component - swift 🤖 component - codegen related to the codegen core packages labels Jul 12, 2019
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift stuff looks good - I'd appreciate a look from someone who knows TypeScript though!

@trevor-scheer
Copy link
Member

This was just resolved in #1386, apologies that I didn't get to this first and sooner. Feel free to reopen if I've overlooked anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐦 component - swift 🤖 component - codegen related to the codegen core packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants