Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[airbnb] Update Swift codegen to add operation name to generated query classes #1386

Merged
merged 3 commits into from
Jul 15, 2019
Merged

[airbnb] Update Swift codegen to add operation name to generated query classes #1386

merged 3 commits into from
Jul 15, 2019
+20 −0

Conversation

skevy
Copy link
Contributor

@skevy skevy commented Jul 11, 2019 •
edited
Loading

Updates Swift codegen to add the operation name to generated query classes.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@designatednerd
Copy link
Contributor

@skevy Looks like there's a few tests and/or their sample code which need to be updated

@skevy
Copy link
Contributor Author

skevy commented Jul 11, 2019

Whoops! This is what I get for doing this so late at night. Will do. Sorry about that!

@skevy skevy force-pushed the skevy--add-operation-name branch from 53b50c5 to 7ba9e9f Compare July 11, 2019 16:52
@skevy skevy force-pushed the skevy--add-operation-name branch from 7ba9e9f to 3abd28f Compare July 11, 2019 18:03
designatednerd
designatednerd reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift LGTM, would appreciate a look from someone who knows typescript!

trevor-scheer
trevor-scheer reviewed Jul 15, 2019
View reviewed changes
@trevor-scheer trevor-scheer merged commit 006cb61 into apollographql:master Jul 15, 2019
@trevor-scheer trevor-scheer mentioned this pull request Jul 15, 2019
Closed
4 tasks
@skevy skevy mentioned this pull request Jul 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd left review comments

@trevor-scheer trevor-scheer trevor-scheer left review comments

Assignees
No one assigned
Labels
🐦 component - swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skevy @designatednerd @trevor-scheer