adopt AIP-61 terminology for consistency

[alinush]

Description

[trunk-io]

⏱️ 21h 52m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-move-unit-coverage	4h 2m	🟩 ⬜ ⬜ ⬜ 🟩 (+5 more)
windows-build	3h 28m	🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-unit-tests	2h 47m	⬜ 🟥 ⬜ ⬜ 🟩 (+4 more)
rust-move-tests	2h 33m	🟩 ⬜ ⬜ 🟩 🟩 (+5 more)
execution-performance / single-node-performance	1h 34m	🟩 🟩 🟩 🟥 🟩
rust-smoke-tests	1h 28m	🟩 ⬜ ⬜ 🟩
run-tests-main-branch	1h 3m	🟥 🟥 🟥 🟥 🟥 (+5 more)
rust-images / rust-all	1h	🟩 🟩 🟩 🟩
rust-lints	51m	⬜ 🟩 🟩 🟩 🟩 (+4 more)
forge-e2e-test / forge	36m	🟩 ⬜ ⬜ 🟩
forge-compat-test / forge	35m	🟩 ⬜ ⬜ 🟩
check	34m	🟩 🟩 ⬜ 🟩 🟩 (+5 more)
cli-e2e-tests / run-cli-tests	26m	🟥 ⬜ ⬜ 🟥
check-dynamic-deps	24m	🟩 🟩 🟩 🟩 🟩 (+6 more)
general-lints	17m	⬜ 🟩 🟩 🟩 🟩 (+4 more)
semgrep/ci	5m	🟩 🟩 🟩 🟩 🟩 (+6 more)
node-api-compatibility-tests / node-api-compatibility-tests	4m	🟩 🟩 🟩 🟩
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+5 more)
file_change_determinator	2m	🟩 🟩 ⬜ 🟩 🟩 (+5 more)
execution-performance / file_change_determinator	53s	🟩 🟩 🟩 🟩 🟩
permission-check	52s	🟩 🟩 🟩 🟩 🟩 (+6 more)
file_change_determinator	40s	🟩 🟩 🟩 🟩
permission-check	34s	🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check	31s	🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check	29s	🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check	9s	🟩 🟩 ⬜ 🟩 🟩
determine-docker-build-metadata	7s	🟩 🟩 🟩 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-images / rust-all	16m	13m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[heliuchuan]

lgtm

[codecov]

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (d771cec) 71.4% compared to head (853648b) 71.4%.
Report is 6 commits behind head on main.

❗ Current head 853648b differs from pull request most recent head eaf0cbf. Consider uploading reports for the commit eaf0cbf to get more accurate results

Files	Patch %	Lines
aptos-move/aptos-vm/src/oidb_validation.rs	9.0%	20 Missing ⚠️
types/src/oidb/test_utils.rs	0.0%	6 Missing ⚠️
types/src/transaction/authenticator.rs	0.0%	6 Missing ⚠️
types/src/transaction/mod.rs	0.0%	5 Missing ⚠️
types/src/oidb/mod.rs	33.3%	4 Missing ⚠️
types/src/on_chain_config/aptos_features.rs	0.0%	4 Missing ⚠️
types/src/oidb/bn254_circom.rs	0.0%	3 Missing ⚠️
types/src/oidb/circuit_testcases.rs	0.0%	3 Missing ⚠️
types/src/oidb/configuration.rs	66.6%	1 Missing ⚠️
types/src/oidb/openid_sig.rs	0.0%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12123   +/-   ##
=======================================
  Coverage    71.4%    71.4%           
=======================================
  Files         810      810           
  Lines      184821   184821           
=======================================
+ Hits       132005   132052   +47     
+ Misses      52816    52769   -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Forge suite compat success on aptos-node-v1.9.5 ==> eaf0cbfab21e21f1bcc0227b6895d74f53b73013

Compatibility test results for aptos-node-v1.9.5 ==> eaf0cbfab21e21f1bcc0227b6895d74f53b73013 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6150 txn/s, latency: 5234 ms, (p50: 4800 ms, p90: 10800 ms, p99: 11600 ms), latency samples: 227580
2. Upgrading first Validator to new version: eaf0cbfab21e21f1bcc0227b6895d74f53b73013
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 634 txn/s, submitted: 669 txn/s, expired: 34 txn/s, latency: 36849 ms, (p50: 43000 ms, p90: 57400 ms, p99: 58800 ms), latency samples: 53339
3. Upgrading rest of first batch to new version: eaf0cbfab21e21f1bcc0227b6895d74f53b73013
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 566 txn/s, submitted: 605 txn/s, expired: 39 txn/s, latency: 37216 ms, (p50: 42900 ms, p90: 53700 ms, p99: 57600 ms), latency samples: 49850
4. upgrading second batch to new version: eaf0cbfab21e21f1bcc0227b6895d74f53b73013
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2314 txn/s, latency: 12944 ms, (p50: 15500 ms, p90: 18800 ms, p99: 19500 ms), latency samples: 106460
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> eaf0cbfab21e21f1bcc0227b6895d74f53b73013 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on eaf0cbfab21e21f1bcc0227b6895d74f53b73013

two traffics test: inner traffic : committed: 7068 txn/s, latency: 5547 ms, (p50: 5400 ms, p90: 6900 ms, p99: 10200 ms), latency samples: 3053700
two traffics test : committed: 100 txn/s, latency: 2195 ms, (p50: 2100 ms, p90: 2500 ms, p99: 4500 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.239, avg: 0.202", "QsPosToProposal: max: 0.441, avg: 0.388", "ConsensusProposalToOrdered: max: 0.601, avg: 0.566", "ConsensusOrderedToCommit: max: 0.531, avg: 0.501", "ConsensusProposalToCommit: max: 1.101, avg: 1.068"]
Max round gap was 1 [limit 4] at version 1312583. Max no progress secs was 3.894912 [limit 15] at version 1312583.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking