merge main to randomnet #12171

zjma · 2024-02-22T18:26:00Z

Description

Test Plan

Co-authored-by: Oliver <[email protected]>

* Duplicated logic for creating the gas meter for view functions has been removed. * Duplicated logic for calculating gas used for view functions has been removed. * There was unreachable code in failure transaction cleanup, where the discarded status has been returned immediately, but then re-checked again. The first check is shifted inside. * No more default transaction metadata. * Scripts are now validated consistently. * Simplifies transaction execution function signature to avoid `Option<String>`. * Removes duplicated features from `AptosVM` and keeps them in `MoveVMExt`. * Fixes a bug when script hash was not computed for `RunOnAbort`. Related tests are moved to `move-e2e-tests`.

Implement a pass to eliminate critical edges by splitting them with empty blocks

### Description The block output limit is no longer hit with p2p txns. ### Test Plan Forge `realistic_env_max_load` TPS improves.

* Minor aggregator cleanup * Addressing PR comments

…dress (#12108) Co-authored-by: Alin Tomescu <[email protected]>

… throughput) (#12124)

* Avoid cloning network sender using Arc pointers * Removing a clone * 100 node sweep test * Removing a few clone operations * reset forge test * Removing some clones * Removing clones

adopt AIP-61 terminology for consistency

…nterfaces (#12104)

* types update from randomnet * update * lint * lint

* All validators broadcast commit messages * Forge testing * Increase timeout for forge * test forge realistic_env_workload_sweep_test * run realistic_env_workload_sweep_test * run realistic_env_workload_sweep_test * run sweep test * increase forge runner duration * forge testing * Letting the proposer also broadcast commit decision for backward compatibility * removing forge changes * Added a TODO

* [vm] Resource access control: runtime engine Implements the runtime engine for resource access control: - a representation of access control specifiers in `loaded_data::runtime_access_specifiers`. - a loader for access specifiers in `runtime::loader::access_specifier_loader`. - a new stateful object representing the access control logic in `runtime::access_control`. - finally the use of the `AccessControlState` in `runtime::interpreter`. * Addressing reviewer comments. * Addressing reviewer comments. * typo: PTLA -> PTAL * Rebasing: adjusting to upstream changes * Rebasing

* update tests * fix bug * fix-12116 * fix missing space * add expected got * remove live-var tests * fix had_erros * fix

codecov · 2024-02-22T19:07:45Z

Codecov Report

Attention: Patch coverage is 65.01650% with 742 lines in your changes are missing coverage. Please review.

Project coverage is 70.1%. Comparing base (9ef872b) to head (f677b1a).
Report is 217 commits behind head on randomnet.

Files	Patch %	Lines
types/src/oidb/circuit_testcases.rs	0.0%	112 Missing ⚠️
types/src/oidb/openid_sig.rs	0.0%	101 Missing ⚠️
types/src/oidb/mod.rs	11.2%	95 Missing ⚠️
types/src/oidb/test_utils.rs	0.0%	75 Missing ⚠️
types/src/oidb/bn254_circom.rs	45.5%	74 Missing ⚠️
...-v2/src/pipeline/split_critical_edges_processor.rs	85.2%	38 Missing ⚠️
types/src/oidb/groth16_sig.rs	0.0%	38 Missing ⚠️
.../types/src/loaded_data/runtime_access_specifier.rs	88.3%	34 Missing ⚠️
types/src/oidb/groth16_vk.rs	54.5%	30 Missing ⚠️
aptos-move/aptos-vm/src/oidb_validation.rs	12.1%	29 Missing ⚠️
... and 15 more

Additional details and impacted files

@@              Coverage Diff               @@
##           randomnet   #12171       +/-   ##
==============================================
+ Coverage       69.8%    70.1%     +0.3%     
==============================================
  Files           2199      854     -1345     
  Lines         417217   189784   -227433     
==============================================
- Hits          291411   133134   -158277     
+ Misses        125806    56650    -69156

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

commit a50ffec Author: Zhoujun Ma <[email protected]> Date: Thu Feb 22 21:10:12 2024 +0000 lint commit 388350f Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 13:04:28 2024 -0800 update commit 76f7eca Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:56:04 2024 -0800 update commit a663542 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:54:18 2024 -0800 update commit b439449 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:34:14 2024 -0800 update commit 3378ceb Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:17:06 2024 -0800 update commit 6cd6685 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:15:05 2024 -0800 update commit 6d89f37 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:13:51 2024 -0800 update commit 980f257 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:12:04 2024 -0800 update commit 16e9349 Author: Zhoujun Ma <[email protected]> Date: Thu Feb 22 18:25:08 2024 +0000 lint

github-actions · 2024-02-22T21:46:12Z

✅ Forge suite `compat` success on `aptos-node-v1.9.5` ==> `f677b1a045fda6ae6d9c9260b5cf918e49b44ea0`

Compatibility test results for aptos-node-v1.9.5 ==> f677b1a045fda6ae6d9c9260b5cf918e49b44ea0 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 5696 txn/s, latency: 5032 ms, (p50: 4800 ms, p90: 5400 ms, p99: 10100 ms), latency samples: 250640
2. Upgrading first Validator to new version: f677b1a045fda6ae6d9c9260b5cf918e49b44ea0
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 786 txn/s, latency: 34698 ms, (p50: 41500 ms, p90: 51900 ms, p99: 53700 ms), latency samples: 56620
3. Upgrading rest of first batch to new version: f677b1a045fda6ae6d9c9260b5cf918e49b44ea0
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 154 txn/s, submitted: 360 txn/s, expired: 205 txn/s, latency: 34749 ms, (p50: 41700 ms, p90: 53800 ms, p99: 96600 ms), latency samples: 20968
4. upgrading second batch to new version: f677b1a045fda6ae6d9c9260b5cf918e49b44ea0
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2959 txn/s, latency: 10229 ms, (p50: 9800 ms, p90: 17200 ms, p99: 17800 ms), latency samples: 136140
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> f677b1a045fda6ae6d9c9260b5cf918e49b44ea0 passed
Test Ok

github-actions · 2024-02-22T21:46:27Z

✅ Forge suite `realistic_env_max_load` success on `f677b1a045fda6ae6d9c9260b5cf918e49b44ea0`

two traffics test: inner traffic : committed: 7314 txn/s, latency: 5359 ms, (p50: 5100 ms, p90: 6600 ms, p99: 12500 ms), latency samples: 3159940
two traffics test : committed: 100 txn/s, latency: 2171 ms, (p50: 2100 ms, p90: 2300 ms, p99: 7500 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.248, avg: 0.206", "QsPosToProposal: max: 0.457, avg: 0.426", "ConsensusProposalToOrdered: max: 0.583, avg: 0.553", "ConsensusOrderedToCommit: max: 0.453, avg: 0.437", "ConsensusProposalToCommit: max: 1.006, avg: 0.989"]
Max round gap was 1 [limit 4] at version 666671. Max no progress secs was 4.248388 [limit 15] at version 666671.
Test Ok

alinush and others added 30 commits February 19, 2024 03:05

Fix iss-related bug in Groth16 path & refactor (#12017)

0d29ccd

Co-authored-by: Oliver <[email protected]>

[Compiler V2] Critical edge elimination (#11894)

d4fdb8f

Implement a pass to eliminate critical edges by splitting them with empty blocks

[consensus configs] reduce sending block size from 2500 to 1900 (#12091)

9d802b8

### Description The block output limit is no longer hit with p2p txns. ### Test Plan Forge `realistic_env_max_load` TPS improves.

[Indexer-grpc] Add profiling support. (#12034)

6b3219e

Minor aggregator cleanup (#12013)

67f372a

* Minor aggregator cleanup * Addressing PR comments

[move] rotate_authentication_key_call should not modify OriginatingAd…

d771cec

…dress (#12108) Co-authored-by: Alin Tomescu <[email protected]>

[Data Streaming Service] Add dynamic prefetching support

6ce7638

[Data Streaming Service] Add dynamic prefetching unit tests.

47a1f66

[Data Streaming Service] Update existing integration tests.

ea17e7e

[State Sync] Add backpressure to fast sync receiver.

8d24ec7

Update perf baseline for gas charging coverage improvements (reducing…

bc50dae

… throughput) (#12124)

Reduce latency of cloning network sender using Arc pointers (#12103)

9972ea0

* Avoid cloning network sender using Arc pointers * Removing a clone * 100 node sweep test * Removing a few clone operations * reset forge test * Removing some clones * Removing clones

adopt AIP-61 terminology for consistency (#12123)

3bef23f

adopt AIP-61 terminology for consistency

[Consensus] Remove non-decoupled execution and refactor for cleaner i…

055683a

…nterfaces (#12104)

fix jwk key logging (#12090)

5256800

remove spurious error lines (#12137)

122f51f

randomness #1: types update from randomnet (#12106)

6c7e9d4

* types update from randomnet * update * lint * lint

ObjectCodeDeployment API cleanup update (#12133)

e229929

ObjectCodeDeployment API cleanup update (#12141)

ff49622

[Compiler-v2] porting more V1 unit tests to V2 (#12085)

b934829

* update tests * fix bug * fix-12116 * fix missing space * add expected got * remove live-var tests * fix had_erros * fix

Enable the max object nesting check (#12129)

d69d3c1

Resolved the warning for unused variable (#12157)

72906ab

Merge remote-tracking branch 'origin/main' into randomnet

8d7b337

update

108b54c

update

2fb99db

update

bb1ffbb

update

e9d1f6c

zjma removed request for davidiw, rex1fernando, gregnazario, bchocho, alinush, ibalajiarun, JoshLind, sasha8, banool, junkil-park, runtian-zhou, vgao1996, wrwg, gelash, mstraka100, 0xmaayan, georgemitenkov, zekun000, danielxiangzl and movekevin February 22, 2024 18:51

This comment has been minimized.

Sign in to view

zjma merged commit d78f690 into randomnet Feb 22, 2024
45 checks passed

zjma deleted the zjma/merge_main_to_randomnet_2 branch February 22, 2024 23:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge main to randomnet #12171

merge main to randomnet #12171

zjma commented Feb 22, 2024

This comment has been minimized.

This comment has been minimized.

codecov bot commented Feb 22, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 22, 2024

github-actions bot commented Feb 22, 2024

merge main to randomnet #12171

merge main to randomnet #12171

Conversation

zjma commented Feb 22, 2024

Description

Test Plan

This comment has been minimized.

This comment has been minimized.

codecov bot commented Feb 22, 2024 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 22, 2024

✅ Forge suite compat success on aptos-node-v1.9.5 ==> f677b1a045fda6ae6d9c9260b5cf918e49b44ea0

github-actions bot commented Feb 22, 2024

✅ Forge suite realistic_env_max_load success on f677b1a045fda6ae6d9c9260b5cf918e49b44ea0

codecov bot commented Feb 22, 2024 •

edited

Loading

✅ Forge suite `compat` success on `aptos-node-v1.9.5` ==> `f677b1a045fda6ae6d9c9260b5cf918e49b44ea0`

✅ Forge suite `realistic_env_max_load` success on `f677b1a045fda6ae6d9c9260b5cf918e49b44ea0`