Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lanelet2_utility): add intersection/turn_direction definition #244

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 7, 2025

Description

define a common TurnDirection to remove duplicates in autoware core/universe

see the diff here: https://github.com/tier4/autoware.core/compare/fix/lanelet2_utils/link...tier4:autoware.core:feat/autoware_lanelet2_utility-turn_direction?expand=1

depends
#251

image

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Mar 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 79.31034% with 12 lines in your changes missing coverage. Please review.

Project coverage is 46.75%. Comparing base (4cb18f5) to head (2d2a2c6).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
...on/autoware_lanelet2_utility/test/intersection.cpp 71.42% 0 Missing and 12 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #244       +/-   ##
===========================================
- Coverage   78.75%   46.75%   -32.00%     
===========================================
  Files          11       20        +9     
  Lines         193      586      +393     
  Branches       73      192      +119     
===========================================
+ Hits          152      274      +122     
- Misses         11      230      +219     
- Partials       30       82       +52     
Flag Coverage Δ
differential 46.75% <79.31%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soblin soblin force-pushed the feat/autoware_lanelet2_utility-turn_direction branch from 45211dc to fe364f1 Compare March 7, 2025 10:51
@soblin soblin marked this pull request as ready for review March 7, 2025 10:53
@soblin soblin added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Mar 7, 2025
@soblin soblin force-pushed the feat/autoware_lanelet2_utility-turn_direction branch from fe364f1 to 2d2a2c6 Compare March 7, 2025 11:45
Copy link

github-actions bot commented Mar 7, 2025

Documentation URL: https://autowarefoundation.github.io/autoware.core/pr-244/
Modified URLs:

@soblin soblin force-pushed the feat/autoware_lanelet2_utility-turn_direction branch 2 times, most recently from 8f34f6c to 6480af7 Compare March 10, 2025 04:36
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

soblin added 3 commits March 10, 2025 22:46
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the feat/autoware_lanelet2_utility-turn_direction branch from 6480af7 to 2f54549 Compare March 10, 2025 13:46
@soblin soblin enabled auto-merge (squash) March 10, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants