Update AvalancheGo dep to include latest + ACP-118 #1961
Conversation
|
Hmm I haven't seen this before. Locally, one version of this passes the linter and fails compilation and the other vice versa. This is strange... https://github.com/ava-labs/hypersdk/actions/runs/13727774395/job/38398037402#step:4:146 
https://github.com/ava-labs/hypersdk/actions/runs/13727859748/job/38398319055 
|
examples/morpheusvm/go.mod
Outdated
|
|
||
| toolchain go1.22.12 | ||
| toolchain go1.23.7 | ||
|
|
||
| require ( | ||
| github.com/ava-labs/avalanchego v1.12.3-warp-verify6.0.20250209190418-217ef3979ea7 |
There was a problem hiding this comment.
Shouldn't this be the same version as the top-level go.mod?
There was a problem hiding this comment.
Yes, guess it's not enforced by updating the AvalancheGo dep, but we should align them.
There was a problem hiding this comment.
Ah I thought you were referring to the golang toolchain version, this was indeed the fix. Nice catch 🙏
Looks like this was caused by MorpheusVM importing a different version of AvalancheGo in its own Meanwhile, the linter saw a different version, so it failed for a different reason. 🤦 |
| # Make issues output unique by line. | ||
| # Default: true | ||
| uniq-by-line: false |
There was a problem hiding this comment.
| @@ -45,7 +44,7 @@ linters: | |||
| - dupword | |||
| - errcheck | |||
| - errorlint | |||
| - exportloopref | |||
| - copyloopvar | |||
There was a problem hiding this comment.
Changed as of go1.23
| @@ -121,6 +120,7 @@ linters-settings: | |||
| gosec: | |||
| excludes: | |||
| - G107 # Url provided to HTTP request as taint input https://securego.io/docs/rules/g107 | |||
| - G115 # TODO Enable this ruleset in a follow-up PR | |||
There was a problem hiding this comment.
Disable majority of newly introduced linting errors with the golangci / golang version bump
| - structcheck | ||
| # - lll | ||
| # - gomnd | ||
| - goprintffuncname | ||
| - interfacer |
There was a problem hiding this comment.
No longer supported
| @@ -78,8 +78,8 @@ func TestExpiryHeapRemoveEmpty(t *testing.T) { | |||
| eheap := New[*TestItem](0) | |||
| item := GenerateTestItem("sponsor", 1) | |||
| // Require this returns | |||
| eheap.Remove(item.GetID()) | |||
| require.True(true, "not true") | |||
There was a problem hiding this comment.
not sure why this was here originally
Signed-off-by: aaronbuchwald <[email protected]>
This PR updates the AvalancheGo dependency to include the latest version of master + ACP-118 ava-labs/avalanchego#3394
Additionally, using this version results in a coreth dependency conflict, so this depends on ava-labs/avalanchego@6e7a7d5
This PR should be the last we need before depending on the master branch of AvalancheGo as ACP-118 is still blocked, but should be merged soon.