Fix error on SampleType creation while synchronizing with Tamanu #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request fixes an error on the automatic creation of sample type if it does not exist when synchronizing with Tamanu. Underlying reason is that
bika_sampletypesfolder does no longer exist because of senaite/senaite.core#2584Current behavior
System fails when trying to create a SampleType because
bika_sampletypesdoes no longer existDesired behavior
System creates a SampleType for the specimen's type record coming from Tamanu
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.