Migrate SampleType to DX #2584
Merged
Migrate SampleType to DX #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
added
Python 3
|
@xispa thanks for review. hope it is ok now :) |
xispa
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Many thanks, we are almost there!
Besides the comments I've left, please add the counterpart doctests for the two functions you added in senaite.core.api.dtime at https://github.com/senaite/senaite.core/blob/2.x/src/senaite/core/tests/doctests/API_datetime.rst .
Thanks man!
|
@xispa here we go :) the new iteration served :) |
This was referenced Aug 4, 2024
This was referenced Aug 4, 2024
This was referenced Sep 18, 2024
This was referenced Sep 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR migrates the AT SampleType to Dexterity types for Python 3 compatibility.
Current behavior before PR
SampleType is a content type based on the Archetypes framework
Desired behavior after PR is merged
SampleType is a content type based on the Dexterity framework
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.