Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return standard datetime format in ProjectIrodsFileListAPIView #2045

Closed
mikkonie opened this issue Dec 11, 2024 · 1 comment
Closed

Return standard datetime format in ProjectIrodsFileListAPIView #2045

mikkonie opened this issue Dec 11, 2024 · 1 comment
Assignees
@mikkonie
Labels
app: samplesheets Issue in the samplesheets app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Milestone
v1.0.0

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Dec 11, 2024 •
edited
Loading

The format of the modify_time field in the return data is different from other datetime fields in our REST API views. This needs to be fixed of course.

This is technically a breaking change for the API, but we can let it slide as this will be in the new 1.0 version. Needs to be documented as such, of course.

To be done simultaneously with #2040.
@mikkonie mikkonie added breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement app: samplesheets Issue in the samplesheets app labels Dec 11, 2024
@mikkonie mikkonie added this to the v1.0.0 milestone Dec 11, 2024
@mikkonie mikkonie self-assigned this Dec 11, 2024
mikkonie added a commit that referenced this issue Dec 11, 2024
@mikkonie
add api_format in get_objects(), update modify_time field (#2045)
5a82dc6
mikkonie added a commit that referenced this issue Dec 11, 2024
@mikkonie
update ProjectIrodsFileListAPIView return data (#2040, #2045)
9ad5487
@mikkonie
Copy link
Contributor Author

Done. This required adding api_format to IrodsAPI.get_objects() and get_objs_recursively().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: samplesheets Issue in the samplesheets app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@mikkonie