Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to django-sodar-core v1.1 #2051

Open
24 of 37 tasks
mikkonie opened this issue Jan 6, 2025 · 0 comments
Open
24 of 37 tasks

Upgrade to django-sodar-core v1.1 #2051

mikkonie opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Jan 6, 2025

This SODAR Core release contains some breaking changes and other major things to consider. Doing a checklist here.

SODAR Core v1.1.0 milestone

Code Updates

  • Upgrade dependencies
  • Change usages of get_user_display_name() to SODARUser.get_display_name() N/A
  • Refactor usages to removed API view base classes if applicable
  • Define app settings as PluginAppSettingDef objects
  • Use app setting type constants
  • Update uses of AppSettingAPI.get_all() to get_all_by_scope()
  • Support old_owner_role=None in perform_owner_transfer(), add tests
  • Add PROJECTROLES_READ_ONLY_MSG
  • Refactor samplesheets permission tests
  • Refactor landingzones permission tests
  • Refactor other apps' permission tests
  • Add read-only mode permission tests for data modifying views in samplesheets
  • Add read-only mode UI restrictions and UI tests in samplesheets
  • Ensure data request controls are disabled in site read-only mode
  • Add read-only mode permission tests for data modifying views in landingzones
  • Add read-only mode UI restrictions and UI tests in landingzones
  • Add read-only mode permission tests for data modifying views in ontologyaccess
  • Add read-only mode UI restrictions and UI tests in ontologyaccess N/A
  • Add read-only mode permission tests for data modifying views in isatemplates
  • Add read-only mode UI restrictions and UI tests in isatemplates N/A
  • Add read-only mode taskflow restriction and tests in taskflowbackend See (1)
  • Add read-only mode skipping for periodic taskflowbackend tasks
  • Implement and test perform_project_delete()
  • Update delete template header layouts (see Inconsistent heading positioning in confirm delete templates sodar-core#1548)
  • Update OpenAPI schema generation for drf-spectacular
  • Add PROJECTROLES_API_USER_DETAIL_RESTRICT to Django settings
  • Add TOKENS_CREATE_PROJECT_USER_RESTRICT to Django settings

Documentation

  • Add project deletion to manual
  • Update SODAR Core API version info in manual
  • Document project leaving functionality in manual
  • Add note to admin docs on requiring deployment to v1.0 before v1.1 due to database migrations
  • Document removeroles management command
  • Update user docs for owner transfer form "remove role" option
  • Document project list v3
  • Update search documentation for new layout
  • Document PROJECTROLES_API_USER_DETAIL_RESTRICT
  • Document TOKENS_CREATE_PROJECT_USER_RESTRICT

Notes

  1. We actually can't limit this in read-only mode in taskflow, because superusers need to be able to still change data and we don't know about user in the taskflowbackend API.
@mikkonie mikkonie added documentation Improvements or additions to documentation environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement internal Changes invisible to the user or APIs (e.g. refactoring and optimization) labels Jan 6, 2025
@mikkonie mikkonie added this to the v1.1.0 milestone Jan 6, 2025
@mikkonie mikkonie self-assigned this Jan 6, 2025
@mikkonie mikkonie changed the title Upgrade to django-sodar-core v1.1.0 Upgrade to django-sodar-core v1. Mar 4, 2025
@mikkonie mikkonie changed the title Upgrade to django-sodar-core v1. Upgrade to django-sodar-core v1.1 Mar 4, 2025
mikkonie added a commit that referenced this issue Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Development

No branches or pull requests

1 participant