Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Membership test #500

Merged
merged 11 commits into from
Feb 7, 2022
Merged

Add Membership test #500

merged 11 commits into from
Feb 7, 2022

Conversation

ppamorim
Copy link
Contributor

@ppamorim ppamorim commented Feb 5, 2022

HI, as requested, I implemented the test required for crash that I am experiencing in my application.

Here is the demo for the crash in my application:

https://github.com/ppamorim/openraft/tree/bincode-bug/example-raft-kv

You will need to run ./test-cluster.sh, wait it to finish and read the log n1.log. The code that causes the crash is here: https://github.com/ppamorim/openraft/blob/bincode-bug/example-raft-kv/src/store/mod.rs#L230-L244

The struct that causes the problem is here: https://github.com/datafuselabs/openraft/blob/main/openraft/src/membership/membership.rs#L21

@VictorKoenders
Copy link
Contributor

Found some compatibility problems, see #503 for more info

@ppamorim ppamorim force-pushed the trunk branch 2 times, most recently from 2963a64 to b8595e0 Compare February 6, 2022 14:19
@ppamorim ppamorim force-pushed the trunk branch 3 times, most recently from 8fd5b45 to af3415a Compare February 6, 2022 14:27
@ppamorim
Copy link
Contributor Author

ppamorim commented Feb 6, 2022

I am a disaster to rebase with merged branches.

@ppamorim ppamorim force-pushed the trunk branch 3 times, most recently from 23a7c0e to 8fd5b45 Compare February 6, 2022 14:29
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #500 (357b809) into trunk (75a2e0b) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 357b809 differs from pull request most recent head 540c703. Consider uploading reports for the commit 540c703 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #500      +/-   ##
==========================================
+ Coverage   70.72%   70.86%   +0.14%     
==========================================
  Files          46       47       +1     
  Lines        3149     3165      +16     
==========================================
+ Hits         2227     2243      +16     
  Misses        922      922              
Impacted Files Coverage Δ
compatibility/src/lib.rs 51.78% <ø> (ø)
compatibility/src/membership.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a2e0b...540c703. Read the comment docs.

@VictorKoenders VictorKoenders merged commit ea9bddb into bincode-org:trunk Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants