Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 500 #503

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Fix/issue 500 #503

merged 4 commits into from
Feb 7, 2022

Conversation

VictorKoenders
Copy link
Contributor

  • Fixed an issue where serde would decode a sequence with an u32 instead of a usize
  • Added serde to the the_same test for roundtrips, fixed several issues.
  • Fixed backwards compatibility for result, ipv4addr and ipv6addr

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #503 (e1f2cdd) into trunk (3127ff5) will increase coverage by 1.62%.
The diff coverage is 78.43%.

❗ Current head e1f2cdd differs from pull request most recent head a575ed9. Consider uploading reports for the commit a575ed9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #503      +/-   ##
==========================================
+ Coverage   69.09%   70.72%   +1.62%     
==========================================
  Files          44       46       +2     
  Lines        3058     3149      +91     
==========================================
+ Hits         2113     2227     +114     
+ Misses        945      922      -23     
Impacted Files Coverage Δ
src/config.rs 90.47% <ø> (ø)
src/features/serde/mod.rs 33.33% <ø> (-1.67%) ⬇️
tests/alloc.rs 98.33% <ø> (-0.06%) ⬇️
src/features/serde/de_borrowed.rs 22.10% <25.00%> (+0.12%) ⬆️
src/features/serde/ser.rs 69.10% <53.33%> (+35.14%) ⬆️
src/features/serde/de_owned.rs 72.86% <53.84%> (+30.41%) ⬆️
tests/utils.rs 37.17% <69.23%> (+5.36%) ⬆️
tests/serde.rs 96.42% <88.88%> (-1.54%) ⬇️
compatibility/src/lib.rs 51.78% <100.00%> (+0.87%) ⬆️
compatibility/src/misc.rs 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3127ff5...a575ed9. Read the comment docs.

@VictorKoenders VictorKoenders merged commit 75a2e0b into trunk Feb 7, 2022
@VictorKoenders VictorKoenders deleted the fix/issue_500 branch February 7, 2022 15:52
@Stargateur
Copy link

Stargateur commented Feb 23, 2022

This make using serde with config::standard not a thing

#506

@VictorKoenders
Copy link
Contributor Author

We decided to make .write_fixed_array_header the default for config::standard(): #509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants