Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump go version #2316

Merged
merged 1 commit into from
Feb 11, 2025
Merged

deps: bump go version #2316

merged 1 commit into from
Feb 11, 2025

Conversation

rabbitprincess
Copy link
Contributor

Overview

Bump go.mod version from 1.17 to 1.22, related to #2306.

Notes

The current GitHub workflows and Makefile depend on GOPATH. It would be better to update them to use Go Modules.

@rabbitprincess rabbitprincess marked this pull request as ready for review February 10, 2025 08:02
@guggero guggero self-requested a review February 10, 2025 11:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13236114758

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.9%) to 55.309%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
mempool/mempool.go 1 66.67%
database/ffldb/db.go 5 91.23%
Totals Coverage Status
Change from base Build 12775873016: -1.9%
Covered Lines: 29945
Relevant Lines: 54141
💛 - Coveralls

guggero
guggero approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

yyforyongyu
yyforyongyu approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@guggero guggero mentioned this pull request Feb 11, 2025
Merged
@guggero guggero linked an issue Feb 11, 2025 that may be closed by this pull request
Bump go.mod version #2306
Closed
@guggero guggero merged commit 380c66b into btcsuite:master Feb 11, 2025
3 checks passed
@rabbitprincess rabbitprincess mentioned this pull request Feb 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

@yyforyongyu yyforyongyu yyforyongyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump go.mod version
4 participants
@rabbitprincess @coveralls @guggero @yyforyongyu