Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using slices.Contains to simplify the code #2317

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

finaltrip
Copy link
Contributor

This is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

@yyforyongyu
Copy link
Collaborator

Approved CI run.

@finaltrip
Copy link
Contributor Author

Approved CI run.

Sorry, the package cannot be found because the go version used in the current project is too low. This package combination method requires go1.21. Now go1.24 is about to be released. I wonder if the maintainer is interested in updating the go version.

@guggero
Copy link
Collaborator

guggero commented Feb 11, 2025

#2316

@finaltrip
Copy link
Contributor Author

#2316

Updated to the latest code. Please review again.

I am curious whether it is necessary to use slices.Contains directly instead of validDbType.

Copy link
Collaborator

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yyforyongyu yyforyongyu merged commit aa58ce2 into btcsuite:master Feb 13, 2025
3 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13289617170

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on master at 55.32%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/addblock/config.go 0 1 0.0%
cmd/findcheckpoint/config.go 0 1 0.0%
config.go 0 1 0.0%
database/cmd/dbtool/globalconfig.go 0 1 0.0%
Totals Coverage Status
Change from base Build 13258546276: 55.3%
Covered Lines: 29944
Relevant Lines: 54129

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants