Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: upgrade the CI #2331

Merged
merged 4 commits into from
Mar 5, 2025
Merged

github: upgrade the CI #2331

merged 4 commits into from
Mar 5, 2025

Conversation

yyforyongyu
Copy link
Collaborator

We upgrade the actions used in the workflow, and add pull request/issue templates.

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

- [ ] Bug fixes contain tests triggering the bug to prevent regressions.

### Code Style and Documentation
- [ ] The change is not [insubstantial](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#substantial-contributions-only). Typo fixes are not accepted to fight bot spam.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should copy these files (contribution and formatting guidelines) here as well? Since this repo is under its own organization, they could theoretically be different from the Lightning Labs ones...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def will do!

parallel: true

- name: Send btcutil coverage
uses: shogo82148/actions-goveralls@v1
uses: coverallsapp/github-action@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐞

@Roasbeef Roasbeef merged commit 2a64716 into btcsuite:master Mar 5, 2025
3 checks passed
@yyforyongyu yyforyongyu deleted the update-ci branch March 6, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants