-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: upgrade the CI #2331
Merged
+103
−16
Merged
github: upgrade the CI #2331
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
--- | ||
name: Bug report | ||
about: Create a bug report. Please use the discussions section for general or troubleshooting questions. | ||
title: '[bug]: ' | ||
labels: ["bug", "needs triage"] | ||
assignees: '' | ||
--- | ||
|
||
### Background | ||
|
||
Describe your issue here. | ||
|
||
### Your environment | ||
|
||
* version of `btcd` | ||
* which operating system (`uname -a` on *Nix) | ||
* any other relevant environment details | ||
|
||
### Steps to reproduce | ||
|
||
Tell us how to reproduce this issue. Please provide stacktraces and links to code in question. | ||
|
||
### Expected behaviour | ||
|
||
Tell us what should happen | ||
|
||
### Actual behaviour | ||
|
||
Tell us what happens instead |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
blank_issues_enabled: false | ||
contact_links: | ||
- name: Discussions | ||
url: https://github.com/btcsuite/btcd/discussions | ||
about: For general or troubleshooting questions or if you're not sure what issue type to pick. | ||
- name: Community Slack | ||
url: https://lightning.engineering/slack.html | ||
about: Please ask and answer questions here. | ||
- name: Security issue disclosure policy | ||
url: https://github.com/lightningnetwork/lnd#security | ||
about: Please refer to this document when reporting security related issues. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest a new feature for `btcd`. | ||
title: '[feature]: ' | ||
labels: enhancement | ||
assignees: '' | ||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] --> | ||
|
||
**Describe the solution you'd like** | ||
<!-- A clear and concise description of what you want to happen. --> | ||
|
||
**Describe alternatives you've considered** | ||
<!-- A clear and concise description of any alternative solutions or features you've considered. --> | ||
|
||
**Additional context** | ||
<!-- Add any other context or screenshots about the feature request here. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
## Change Description | ||
Description of change / link to associated issue. | ||
|
||
## Steps to Test | ||
Steps for reviewers to follow to test the change. | ||
|
||
## Pull Request Checklist | ||
### Testing | ||
- [ ] Your PR passes all CI checks. | ||
- [ ] Tests covering the positive and negative (error paths) are included. | ||
- [ ] Bug fixes contain tests triggering the bug to prevent regressions. | ||
|
||
### Code Style and Documentation | ||
- [ ] The change is not [insubstantial](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#substantial-contributions-only). Typo fixes are not accepted to fight bot spam. | ||
- [ ] The change obeys the [Code Documentation and Commenting](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#code-documentation-and-commenting) guidelines, and lines wrap at 80. | ||
- [ ] Commits follow the [Ideal Git Commit Structure](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#ideal-git-commit-structure). | ||
- [ ] Any new logging statements use an appropriate subsystem and logging level. | ||
|
||
📝 Please see our [Contribution Guidelines](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md) for further guidance. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,12 +13,12 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- name: Set up Go | ||
uses: actions/setup-go@v2 | ||
uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{ env.GO_VERSION }} | ||
|
||
- name: Check out source | ||
uses: actions/checkout@v2 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Build | ||
run: make build | ||
|
@@ -28,46 +28,55 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- name: Set up Go | ||
uses: actions/setup-go@v2 | ||
uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{ env.GO_VERSION }} | ||
|
||
- name: Check out source | ||
uses: actions/checkout@v2 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Test | ||
run: make unit-cover | ||
|
||
- name: Send top-level coverage | ||
uses: shogo82148/actions-goveralls@v1 | ||
uses: coverallsapp/github-action@v2 | ||
continue-on-error: true | ||
with: | ||
path-to-profile: coverage.txt | ||
file: coverage.txt | ||
flag-name: btcd | ||
format: 'golang' | ||
parallel: true | ||
|
||
- name: Send btcec | ||
uses: shogo82148/actions-goveralls@v1 | ||
uses: coverallsapp/github-action@v2 | ||
continue-on-error: true | ||
with: | ||
path-to-profile: btcec/coverage.txt | ||
file: btcec/coverage.txt | ||
flag-name: btcec | ||
format: 'golang' | ||
parallel: true | ||
|
||
- name: Send btcutil coverage | ||
uses: shogo82148/actions-goveralls@v1 | ||
uses: coverallsapp/github-action@v2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 |
||
continue-on-error: true | ||
with: | ||
path-to-profile: btcutil/coverage.txt | ||
file: btcutil/coverage.txt | ||
flag-name: btcutil | ||
format: 'golang' | ||
parallel: true | ||
|
||
- name: Send btcutil coverage for psbt package | ||
uses: shogo82148/actions-goveralls@v1 | ||
uses: coverallsapp/github-action@v2 | ||
continue-on-error: true | ||
with: | ||
path-to-profile: btcutil/psbt/coverage.txt | ||
file: btcutil/psbt/coverage.txt | ||
flag-name: btcutilpsbt | ||
format: 'golang' | ||
parallel: true | ||
|
||
- name: Notify coveralls all reports sent | ||
uses: shogo82148/actions-goveralls@v1 | ||
uses: coverallsapp/github-action@v2 | ||
continue-on-error: true | ||
with: | ||
parallel-finished: true | ||
|
||
|
@@ -76,12 +85,12 @@ jobs: | |
runs-on: ubuntu-latest | ||
steps: | ||
- name: Set up Go | ||
uses: actions/setup-go@v2 | ||
uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{ env.GO_VERSION }} | ||
|
||
- name: Check out source | ||
uses: actions/checkout@v2 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Test | ||
run: make unit-race |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should copy these files (contribution and formatting guidelines) here as well? Since this repo is under its own organization, they could theoretically be different from the Lightning Labs ones...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def will do!