Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbcode [b] button misaligned across themes #136

Closed
cburschka opened this issue Dec 25, 2014 · 5 comments
Closed

bbcode [b] button misaligned across themes #136

cburschka opened this issue Dec 25, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@cburschka
Copy link
Owner

I don't know when this first crept in (definitely <1.4 release), but the [b] button is positioned several pixels lower than the other ones. Screenshots:

screenshot from 2014-12-25 14 02 13
screenshot from 2014-12-25 14 04 01
screenshot from 2014-12-25 14 04 22

And so forth.

@cburschka cburschka added the bug label Dec 25, 2014
@cburschka cburschka self-assigned this Dec 25, 2014
@cburschka cburschka added this to the cadence 1.5 milestone Dec 25, 2014
@cburschka
Copy link
Owner Author

(It's also vertically smaller than the others.)

@cburschka
Copy link
Owner Author

crept in

... I could swear I'd have noticed that kind of error, but apparently it's been there all along. All the way back since the styles were first added to this repository.

Oh well, high time to fix it.

@cburschka
Copy link
Owner Author

Experimenting shows that this is a direct effect of font-weight:bold.

screenshot from 2014-12-25 17 40 59

@cburschka cburschka modified the milestones: cadence 2.0, cadence 1.5 Dec 25, 2014
@cburschka
Copy link
Owner Author

This has to do with line height, vertical alignment, and other things.

There might be a better fix, but this seems to do fine:

#bbCodeContainer button { line-height:1.4em }
#bbCodeContainer button[value=b] { vertical-align:bottom }

(note that aligning all buttons to the bottom will move the entire row up; for some reason it works if only the [b] button is bottom-aligned.)

@cburschka
Copy link
Owner Author

Now the b is a bit higher up than the other labels, but that's less noticeable than the button itself being misaligned.

@cburschka cburschka modified the milestones: cadence 1.5, cadence 2.0 Dec 25, 2014
cburschka added a commit to calref/cadence that referenced this issue Dec 29, 2014
(Bumped version to 1.5-calref)

"Sombra"
========

Features
--------

- cburschka#111: Ctrl+B, I, S and U will automatically add the corresponding BBCode tags
        around the cursor or selected text.

- cburschka#120: The /affiliate command allows admins and owners to set a user's room
        affiliation.

- cburschka#129: Messages can be locally hidden (and unhidden) by clickin an "X" next to
        the message.

- cburschka#131: The tab key will automaticallly complete any partial nickname or chat
        command in the input field.

- cburschka#133: The current room ID is now bound to the URL fragment ("#lounge"). This
        allows bookmarking or linking directly to rooms, as well as inviting
        other cadence users to a room by sending a [url=#room][/url] link.

-       New ponicon: :symad:

Enhancements
------------

-  cburschka#62: The user's own roster entry is emphasized.

-  cburschka#74: Instead of a settings cookie, cadence now uses HTML5 local storage.
        This has an increased size limit and is not sent to the server.

-  cburschka#78: Emoticon codes inside <code> tags are not rendered.

- cburschka#123: The user roster is now sorted alphabetically.

- cburschka#126: On the arrival of a user whose nickname matches an alert keyword, the
        "mention" sound will be played.

- cburschka#135: The help sidebar is updated with all new commands. Admin commands are
        grouped under a separate section. The commands themselves are printed
        as code, instead of being italicized.

- cburschka#139: Raised maximum displayed nickname length from 32 to 48.

Bugfixes
--------

- cburschka#116: Fixed a regression in the /msg command regex.

- cburschka#119: Fix the "Connection failed (improper-addressing)" error when restarting
        after a remote-dropped connection, caused by a stale connection object.

- cburschka#122: Skip code compression when YUI is not installed.

- cburschka#124: When clicking on a nickname with spaces, and then clicking another user,
        only the first part of the nickname was replaced in the input field.

- cburschka#128: /bans printed a poorly formatted message with an empty banlist.

- cburschka#134: Removed the last remnants of the never-displayed splash page.

- cburschka#136: Fixed an alignment problem affecting the [b] button on some devices.
        The bold font weight caused the button to be placed slightly lower than
        the others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant