Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make accidental emoticons less common #78

Closed
cburschka opened this issue Feb 5, 2014 · 3 comments
Closed

Make accidental emoticons less common #78

cburschka opened this issue Feb 5, 2014 · 3 comments
Assignees
@cburschka
Labels
enhancement
Milestone
1.5 - Sombra

Comments

@cburschka
Copy link
Owner

(2014-02-05 02:09:54) Iffy: # If true, Nether Quartz ore will be a NetherOre and will follow the same rules as all other NetherOres. B:OverrideNetherQuartz=true

In the above context, an emoticon is probably not intended.

:O:O:O:O

In the above context, an emoticon is probably intended.

Maybe the parser can be a bit more clever.
@ghost ghost assigned cburschka Feb 5, 2014
@cburschka cburschka modified the milestones: cadence 1.4, cadence-2.0 Feb 10, 2014
@cburschka cburschka modified the milestones: cadence-2.0, cadence 1.3 Mar 22, 2014
@sylae
Copy link
Contributor

sylae commented May 25, 2014

Maybe we can tell the emote parser to ignore anything in code tags? It seems most of the accidental emotes are in code tags (or content that should be in code tags) so that probably would knock out most of these.

@cburschka
Copy link
Owner Author

That seems pretty feasible. The emoticon rendering is already done via jquery-replacetext inside the text nodes of the interpreted HTML, so it could possibly be restricted.

@cburschka cburschka modified the milestones: cadence 1.5, cadence-2.0 May 25, 2014
@cburschka
Copy link
Owner Author

Update: 8) isn't actually a thing on cadence, thankfully.

cburschka added a commit to calref/cadence that referenced this issue Dec 29, 2014
@cburschka
Merge tag 'v1.5' into calref
075e886 
(Bumped version to 1.5-calref)

"Sombra"
========

Features
--------

- cburschka#111: Ctrl+B, I, S and U will automatically add the corresponding BBCode tags
        around the cursor or selected text.

- cburschka#120: The /affiliate command allows admins and owners to set a user's room
        affiliation.

- cburschka#129: Messages can be locally hidden (and unhidden) by clickin an "X" next to
        the message.

- cburschka#131: The tab key will automaticallly complete any partial nickname or chat
        command in the input field.

- cburschka#133: The current room ID is now bound to the URL fragment ("#lounge"). This
        allows bookmarking or linking directly to rooms, as well as inviting
        other cadence users to a room by sending a [url=#room][/url] link.

-       New ponicon: :symad:

Enhancements
------------

-  cburschka#62: The user's own roster entry is emphasized.

-  cburschka#74: Instead of a settings cookie, cadence now uses HTML5 local storage.
        This has an increased size limit and is not sent to the server.

-  cburschka#78: Emoticon codes inside <code> tags are not rendered.

- cburschka#123: The user roster is now sorted alphabetically.

- cburschka#126: On the arrival of a user whose nickname matches an alert keyword, the
        "mention" sound will be played.

- cburschka#135: The help sidebar is updated with all new commands. Admin commands are
        grouped under a separate section. The commands themselves are printed
        as code, instead of being italicized.

- cburschka#139: Raised maximum displayed nickname length from 32 to 48.

Bugfixes
--------

- cburschka#116: Fixed a regression in the /msg command regex.

- cburschka#119: Fix the "Connection failed (improper-addressing)" error when restarting
        after a remote-dropped connection, caused by a stale connection object.

- cburschka#122: Skip code compression when YUI is not installed.

- cburschka#124: When clicking on a nickname with spaces, and then clicking another user,
        only the first part of the nickname was replaced in the input field.

- cburschka#128: /bans printed a poorly formatted message with an empty banlist.

- cburschka#134: Removed the last remnants of the never-displayed splash page.

- cburschka#136: Fixed an alignment problem affecting the [b] button on some devices.
        The bold font weight caused the button to be placed slightly lower than
        the others.
@cburschka cburschka mentioned this issue Apr 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cburschka cburschka

Labels
enhancement
Projects
None yet
Milestone
1.5 - Sombra
Development

No branches or pull requests
2 participants
@cburschka @sylae