Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plain-text formatting. #272

Closed
cburschka opened this issue Aug 5, 2015 · 1 comment
Closed

Plain-text formatting. #272

cburschka opened this issue Aug 5, 2015 · 1 comment
Assignees
@cburschka
Labels
bug
Milestone
1.10.0 - Starlight

Comments

@cburschka
Copy link
Owner

When sending a message, we first render BBCode to HTML, and then attach the .text() output of that HTML as a plaintext alternative.

This is crap. It strips out important parts of the HTML, such as image tags and links, and removes meaningful emphasis markup.

Plain text should contain at least a markdown-resembling version (think ) of the original markup. Either generated from HTML or directly from BBCode, whichever is easier.

(I'm thinking the former is easier.)
@cburschka cburschka added the bug label Aug 5, 2015
@cburschka cburschka self-assigned this Aug 5, 2015
@cburschka cburschka added this to the cadence 1.10 milestone Aug 5, 2015
@cburschka
Copy link
Owner Author

It turns out the latter was easier.

cburschka added a commit that referenced this issue Aug 7, 2015
@cburschka
Re #272: Avoid double-escaping plaintext.
8a57650 
The plaintext message is XML-escaped by Strophe,
and should not be run through visual.format.plain.

Also, truncation should be performed before escaping.
cburschka added a commit that referenced this issue Aug 7, 2015
@cburschka
Re #272: Update chat.formatOutgoing doc comment.
4f9730c 
The return type has changed.
cburschka added a commit to calref/cadence that referenced this issue Dec 16, 2015
@cburschka
Merge tag 'v1.10.0' into calref
43d782e 
1.10.0 - Starlight
==================

This long-delayed release makes minor improvements to the UI, fixes several bugs
in room history and plaintext message bodies, and adds eleven new ponicons.

Features
--------

- cburschka#252: Print role and affiliation changes.
- cburschka#254: /admin command is now interactive.
- cburschka#260: Changes to the timestamp format are now applied retroactively.
- cburschka#266: New :flutterkay: emote.
- cburschka#272: Reformat the plaintext body as Markdown.
- cburschka#275: The OMG theme has been removed.
- cburschka#281: Ten new ponicons: :goodjob:, :calm: :ajcry:, :ajdoubt:, :pinkieglare:,
        :rarityeww:, :spikewhoa:, :skeptiloo:, :twipbbt: and :wasntme:.

Bugfixes
--------

- cburschka#204: Install jquery-ui icons in the CDN prefix.
- cburschka#256: Add the navigation bar links' anchor texts.
- cburschka#257: Style the dialog buttons in the "dash" theme.
- cburschka#258: Strip backslashes in command arguments.
- cburschka#264: If other clients send only a plaintext body, escape it.
- cburschka#265: Attribute delayed messages by JID, not by nick.
- cburschka#267: Add JID (and flair classes) to history authors who are now absent.
- cburschka#268: Make an empty alert field not cause an alert on all messages.
- cburschka#273: Handle "forbidden" message error.
- cburschka#274: Convert JID user class to lower-case.
- cburschka#276: Fix a crash when joining a room with verbosity turned off.
- cburschka#278: Strip hidden markup when saving an HTML log.

Minor changes
-------------

- cburschka#263: The /version command no longer prefixes the version with "cadence-".
- Refactor chat.commands to alphabetical order.
- cburschka#277: Update the JS libraries.
- Add doc comments to visual.messagesToText and visual.ellipsis.
- cburschka#280: All CalRef-specific ponicons have been removed from the master branch.
- cburschka#282: Store the persistent font color as a data attribute, not a class.
cburschka added a commit that referenced this issue Dec 20, 2015
@cburschka
Merge tag 'v1.10.0' into generic
3bae74a 
1.10.0 - Starlight
==================

This long-delayed release makes minor improvements to the UI, fixes several bugs
in room history and plaintext message bodies, and adds eleven new ponicons.

Features
--------

- #252: Print role and affiliation changes.
- #254: /admin command is now interactive.
- #260: Changes to the timestamp format are now applied retroactively.
- #272: Reformat the plaintext body as Markdown.
- #275: The OMG theme has been removed.

Bugfixes
--------

- #204: Install jquery-ui icons in the CDN prefix.
- #256: Add the navigation bar links' anchor texts.
- #257: Style the dialog buttons in the "dash" theme.
- #258: Strip backslashes in command arguments.
- #264: If other clients send only a plaintext body, escape it.
- #265: Attribute delayed messages by JID, not by nick.
- #267: Add JID (and flair classes) to history authors who are now absent.
- #268: Make an empty alert field not cause an alert on all messages.
- #273: Handle "forbidden" message error.
- #274: Convert JID user class to lower-case.
- #276: Fix a crash when joining a room with verbosity turned off.
- #278: Strip hidden markup when saving an HTML log.

Minor changes
-------------

- #263: The /version command no longer prefixes the version with "cadence-".
- Refactor chat.commands to alphabetical order.
- #277: Update the JS libraries.
- Add doc comments to visual.messagesToText and visual.ellipsis.
- #280: All CalRef-specific ponicons have been removed from the master branch.
- #282: Store the persistent font color as a data attribute, not a class.

Conflicts:
	VERSION
	emoticon-packs/ponicons/emoticons.conf
	emoticon-packs/ponicons/sombra.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cburschka cburschka

Labels
bug
Projects
None yet
Milestone
1.10.0 - Starlight
Development

No branches or pull requests
1 participant
@cburschka