Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data attribute for text color #282

Closed
cburschka opened this issue Dec 14, 2015 · 1 comment
Closed

Use data attribute for text color #282

cburschka opened this issue Dec 14, 2015 · 1 comment
Assignees
Labels

Comments

@cburschka
Copy link
Owner

The text color is still sent as <span class="color color-xxxxxx"></span> even though that's annoying to parse and better implemented with a data attribute.

@cburschka cburschka added the bug label Dec 14, 2015
@cburschka cburschka self-assigned this Dec 14, 2015
@cburschka cburschka added this to the cadence 1.10 milestone Dec 14, 2015
@cburschka
Copy link
Owner Author

(This breaks backward compatibility, in that users of the new client and users of the old client will not see each others' text colors.)

cburschka added a commit to calref/cadence that referenced this issue Dec 16, 2015
1.10.0 - Starlight
==================

This long-delayed release makes minor improvements to the UI, fixes several bugs
in room history and plaintext message bodies, and adds eleven new ponicons.

Features
--------

- cburschka#252: Print role and affiliation changes.
- cburschka#254: /admin command is now interactive.
- cburschka#260: Changes to the timestamp format are now applied retroactively.
- cburschka#266: New :flutterkay: emote.
- cburschka#272: Reformat the plaintext body as Markdown.
- cburschka#275: The OMG theme has been removed.
- cburschka#281: Ten new ponicons: :goodjob:, :calm: :ajcry:, :ajdoubt:, :pinkieglare:,
        :rarityeww:, :spikewhoa:, :skeptiloo:, :twipbbt: and :wasntme:.

Bugfixes
--------

- cburschka#204: Install jquery-ui icons in the CDN prefix.
- cburschka#256: Add the navigation bar links' anchor texts.
- cburschka#257: Style the dialog buttons in the "dash" theme.
- cburschka#258: Strip backslashes in command arguments.
- cburschka#264: If other clients send only a plaintext body, escape it.
- cburschka#265: Attribute delayed messages by JID, not by nick.
- cburschka#267: Add JID (and flair classes) to history authors who are now absent.
- cburschka#268: Make an empty alert field not cause an alert on all messages.
- cburschka#273: Handle "forbidden" message error.
- cburschka#274: Convert JID user class to lower-case.
- cburschka#276: Fix a crash when joining a room with verbosity turned off.
- cburschka#278: Strip hidden markup when saving an HTML log.

Minor changes
-------------

- cburschka#263: The /version command no longer prefixes the version with "cadence-".
- Refactor chat.commands to alphabetical order.
- cburschka#277: Update the JS libraries.
- Add doc comments to visual.messagesToText and visual.ellipsis.
- cburschka#280: All CalRef-specific ponicons have been removed from the master branch.
- cburschka#282: Store the persistent font color as a data attribute, not a class.
cburschka added a commit that referenced this issue Dec 20, 2015
1.10.0 - Starlight
==================

This long-delayed release makes minor improvements to the UI, fixes several bugs
in room history and plaintext message bodies, and adds eleven new ponicons.

Features
--------

- #252: Print role and affiliation changes.
- #254: /admin command is now interactive.
- #260: Changes to the timestamp format are now applied retroactively.
- #272: Reformat the plaintext body as Markdown.
- #275: The OMG theme has been removed.

Bugfixes
--------

- #204: Install jquery-ui icons in the CDN prefix.
- #256: Add the navigation bar links' anchor texts.
- #257: Style the dialog buttons in the "dash" theme.
- #258: Strip backslashes in command arguments.
- #264: If other clients send only a plaintext body, escape it.
- #265: Attribute delayed messages by JID, not by nick.
- #267: Add JID (and flair classes) to history authors who are now absent.
- #268: Make an empty alert field not cause an alert on all messages.
- #273: Handle "forbidden" message error.
- #274: Convert JID user class to lower-case.
- #276: Fix a crash when joining a room with verbosity turned off.
- #278: Strip hidden markup when saving an HTML log.

Minor changes
-------------

- #263: The /version command no longer prefixes the version with "cadence-".
- Refactor chat.commands to alphabetical order.
- #277: Update the JS libraries.
- Add doc comments to visual.messagesToText and visual.ellipsis.
- #280: All CalRef-specific ponicons have been removed from the master branch.
- #282: Store the persistent font color as a data attribute, not a class.

Conflicts:
	VERSION
	emoticon-packs/ponicons/emoticons.conf
	emoticon-packs/ponicons/sombra.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant