fix: wait until deployment stabilizes to set status Ready #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Valderrama <[email protected]>
avorima
force-pushed
the
fix-version-ready
branch
from
0067e2b to
0406f63
Compare
✅ Deploy Preview for kamaji-documentation canceled.
|
✅ Deploy Preview for kamaji-documentation canceled.
|
| @@ -106,6 +107,20 @@ func (r *KubernetesDeploymentResource) isProgressingUpgrade() bool { | |||
| return true | |||
| } | |||
|
|
|||
| // An update is complete when new pods are ready and old pods deleted. | |||
| desired := ptr.Deref(r.resource.Spec.Replicas, 2) | |||
There was a problem hiding this comment.
// Deref dereferences ptr and returns the value it points to if no nil, or else
// returns def.
func Deref[T any](ptr *T, def T) T {
Why did you pick 2 here?
There was a problem hiding this comment.
because it's the default. in reality this should never use the default because the field is always set, so i could just dereference. but if this code is ever unit tested it would be something to look out for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some connection interruptions when connecting to the kube-apiserver after a version update.
This change aims to improve this by making sure that all pods are updated and ready before marking the version status as
Ready.