Update to ember data 1.0.0 beta.19 #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating from base code
…recation warning)
Conflicts: addon/serializers/application.js
…seem to be working fine here
…stead of an empty array
…er-parse-adapter into ember-data-1.13.8
… for an empty hasmany relationship
| @@ -86,7 +86,7 @@ export default DS.RESTSerializer.extend({ | |||
| // the links property so the adapter can async call the | |||
| // relationship. | |||
| // The adapter findHasMany has been overridden to make use of this. | |||
| if(options.relation) { | |||
There was a problem hiding this comment.
Recall what was happening here?
There was a problem hiding this comment.
Release notes said that the typeForRoot function had been changed to modelNameFromPayloadKey
There was a problem hiding this comment.
I just meant options.relationship vs options.array. I recall now, they are two different options for how to persist a relationship. One with an array of ids, one with w URL.
There was a problem hiding this comment.
Ah my bad. See my comment below about that. Not sure what should be happening with those two options.
|
@mixonic is there anything else I can do to get this ready to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.