Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need whitelist to avoid external redirect #28

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Need whitelist to avoid external redirect #28

merged 1 commit into from
Apr 7, 2020

Conversation

pburkholder
Copy link
Contributor

@pburkholder pburkholder commented Apr 7, 2020 •
edited
Loading

Changes proposed in this pull request:

security considerations

Closes potential external redirect issue

@pburkholder pburkholder requested a review from a team April 7, 2020 15:51
@siennathesane siennathesane merged commit 7465ce9 into master Apr 7, 2020
@siennathesane siennathesane deleted the pdb/add-sso-whitelist branch April 7, 2020 16:02
@tammersaleh
Copy link
Contributor

For future ref, we should have used ((staging-cf-route)) here. I'll submit a new PR. Don't think this is a CUI issue.

@tammersaleh tammersaleh mentioned this pull request Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siennathesane siennathesane siennathesane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pburkholder @tammersaleh @siennathesane