Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vars instead of hardcoded urls #29

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Use vars instead of hardcoded urls #29

merged 1 commit into from
Apr 14, 2020

Conversation

tammersaleh
Copy link
Contributor

Changes proposed in this pull request:

Use vars instead of hardcoded url

security considerations

None

@tammersaleh tammersaleh requested review from pburkholder and siennathesane and removed request for pburkholder April 7, 2020 16:54
@tammersaleh
Copy link
Contributor Author

Improves on #28

siennathesane
siennathesane approved these changes Apr 13, 2020
View reviewed changes
Copy link

@siennathesane siennathesane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure this change is worth it but it's not a difficult change to walk back from, so no reason not to merge it.

@tammersaleh tammersaleh merged commit ff5b65c into master Apr 14, 2020
@tammersaleh tammersaleh deleted the tsaleh/fix-hard-coded-url branch April 14, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siennathesane siennathesane siennathesane approved these changes

@pburkholder pburkholder Awaiting requested review from pburkholder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammersaleh @siennathesane