Fix create app issues related to route visiblility/permissions #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Sep 6, 2017
richard-cox
commented
- Ensure we only check for non-empty port/host/path during route exist call
- Handle failed to create/bind route in create app flow a bit better
- Better error message
- Refresh app wall on cancel
- Optionally show cross in detail-view (to allow wizard to control dismiss params)
- Show CF api version in cf summary panel
- Ensure we only check for non-empty port/host/path during route exist call - Handle failed to create/bind route in create app flow a bit better -- Better error message -- Refresh app wall on cancel - Optionally show cross in detail-view (to allow wizard to control dismiss params) - Show CF api version in cf summary panel
- Looks like this issue was always shown as an error but only intermittently as a failure - See - http://bristol-ui-concourse.ngrok.io/builds/300 (error) - http://bristol-ui-concourse.ngrok.io/builds/307 (error and failure)
- "Application View Summary Tab Route Management Application route should show up on CF Endpoints view should allow the route to be un-mapped and then deleted - Failed: unknown error: Element is not clickable at point (1276, 663)" - Couldn't reproduce over several runs locally with both cf's in provo
This was referenced Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.