Fix the combined coverage report #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
changed the base branch from
master
to
fix-create-app-route-errors
richard-cox
changed the base branch from
fix-create-app-route-errors
to
master
nwmac
reviewed
Sep 15, 2017
| @@ -29,11 +31,31 @@ | |||
| }); | |||
|
|
|||
| gulp.task('coverage-combine', function (cb) { | |||
| var combine = require('istanbul-combine'); | |||
There was a problem hiding this comment.
Can we remove this as a dev dependency as well - I don't think its used anywhere else?
There was a problem hiding this comment.
The diff is a bit odd, the line's just moved further down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deps on #1246