cf: moved entity factory schemas to its module #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vítor Avelino <[email protected]>
|
✅ Hey vitoravelino! The commit authors and yourself have already signed the CLA. |
|
LGTM - I'm going to wait a little to merge this into entity-catalogue-store though. |
KlapTrap
pushed a commit
that referenced
this pull request
Jun 19, 2019
* entity-catalogue-store: (57 commits) Fix jasmine exception in build Fixes following merge cf: moved entity factory schemas to its module (#3657) Address todo - use common getCFEntityKey For example from EntityCatalogueHelpers.buildEntityKey(organizationSchemaKey, CF_ENDPOINT_TYPE) to getCFEntityKey(organizationSchemaKey) Add general todo's following review with Nathan Indentation fixes (will make reviewing later much easier) also includes import fixes Fix edit org/space (to allow testing of merge) Fix navigate from org summary to org spaces Fixes following merge Remove unused users.effetct.ts (#3660) Invite user e2e tests (#3382) Support separate auth and token endpoints for the console (#3635) Add e2e uaa helpers, use to create/delete user for remove roles tests (#3651) Allow appVersion in helm chart to be set to a product version (#3637) Get default stack from the Stacks API (#3648) Helm Chart: Add imagelist to the helm chart (#3638) E2E Tests: Update cleanup script to remove test users (#3644) Remove ZenHub (#3652) Disable top level remove user tests to unblock pr's (#3646) Show header in none dashboard pages ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vítor Avelino [email protected]
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: