Added backward compatility to old action types #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are changing the string format of action type and to avoid breaking everything we added the backward compatibility to work with the old format. This way we can slowly transition to the new format without breaking all the features at once. Signed-off-by: Vítor Avelino <[email protected]>
|
✅ Hey vitoravelino! The commit authors and yourself have already signed the CLA. |
added 6 commits
August 20, 2019 10:48
* v3-master: (26 commits) Added fixme Fix e2e test Fix cf init script given changes in broker service (#3746) Update protractor to fix travis e2e tests (#3747) Moved more cf components from core to cf package Two tweaks - Move entityCatalogue clear into testEntityCatalogue, optionally return test if in test env - Move EffectsFeatureTestModule & TEST_CATALOGUE_ENTITIES into own test file Moved some cf components from core to cf package Removed some comments Fix cf-autoscaler unit tests Entity validation fixes Same Tweaks at space level - Show edit quota on space level quota details page - Ensure we return from edit stepper from org's space quota list, org level quota page and space level quota page - Apply permissions to edit quota Tweaks - Show edit quota on org level quota details page - Ensure we return from edit stepper from cf quota list, cf level quota page and org level quota page - Apply permissions to edit quota - Change org --> space in space level quota page - Fix validation for sub 0 values Small tweaks WIP Fix entity relations from parents test Build Fix imports after merge WIP Core - fix compile & current user permissions First pass autoscaler unit tests ...
…-types * entity-pipeline: Fix a few low hanging fruit, added some TODOs for me Remove console logs FIx qparam for service instances
…-types * entity-pipeline: Small fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are changing the string format of action type and to avoid breaking
everything we added the backward compatibility to work with the old
format. This way we can slowly transition to the new format without
breaking all the features at once.
Signed-off-by: Vítor Avelino [email protected]