Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN FD Safety: Split TX and RX checks assignments #1968

Closed

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Mar 10, 2025

@github-actions github-actions bot added the car safety vehicle-specific safety code label Mar 10, 2025
@sunnyhaibin sunnyhaibin force-pushed the hyundai-safety-tx-rx-split branch from 8eda072 to 00e50e5 Compare March 10, 2025 05:26
@sunnyhaibin sunnyhaibin changed the title Hyundai Safety: Split TX and RX checks assignments Hyundai CAN FD Safety: Split TX and RX checks assignments Mar 10, 2025
@sshane
Copy link
Contributor

sshane commented Mar 12, 2025

I worry that this is harder to keep track of because now the if statements are duplicated. The real fix is something like #1800

@sshane sshane closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car safety vehicle-specific safety code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants