kolaTestIso: add coverage for '--pxe-append-rootfs' PXE tests #162
Conversation
Signed-off-by: Nikita Dubrovskii <[email protected]>
nikita-dubrovskii
requested review from
jlebon,
ravanelli,
mike-nguyen,
gursewak1997 and
dustymabe
as code owners
|
This is certainly one way to achieve the goal of coreos/coreos-assembler#4024 but what I was thinking was that when someone runs |
| @@ -31,6 +32,9 @@ def call(params = [:]) { | |||
| // the signatures for the metal images won't have been created yet. | |||
| try { | |||
| shwrap("cd ${cosaDir} && cosa kola testiso --inst-insecure ${extraArgs} --output-dir ${outputDir}/${id}") | |||
| if (!params['skipPxeAppendRootfs']) { | |||
| shwrap("cd ${cosaDir} && cosa kola testiso pxe* --pxe-append-rootfs ${extraArgs} --output-dir ${outputDir}/${id}") | |||
There was a problem hiding this comment.
pxe*
I would pick one or two and not run them all in order to try to not add too much more time to our already really long runtime for testiso tests.
There was a problem hiding this comment.
It's only up to 4 tests depending on arch. We can limit this amount by deny-listing let's say 4k tests, and i'd do it in pipeline repo, not here. Wdyt?
|
I'm happy to merge this strategy if we think the other way is too hard/not worth the effort. Though, something like this does make coreos/coreos-assembler#3989 harder once we try to do that. |
Folding is in progress, but it won't be fast. IMO it makes sense to have these now. |
That would be my preference as well. If it's a switch, then:
|
|
Alternative way - coreos/coreos-assembler#4031 |
|
coreos/coreos-assembler#4031 was merged, closing this |
The
kola testisocommand supports--pxe-append-rootfs, let's adds CI coverage for that.