Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kolaTestIso: add coverage for '--pxe-append-rootfs' PXE tests #162

Closed
wants to merge 1 commit into from
Closed

kolaTestIso: add coverage for '--pxe-append-rootfs' PXE tests #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions vars/kolaTestIso.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// marker: string -- some identifying text to add to uploaded artifact filenames
// skipUEFI: boolean -- skip UEFI tests
// skipSecureBoot boolean -- skip secureboot tests
// skipPxeAppendRootfs boolean -- skip PXE with appended roofs tests

def call(params = [:]) {
def cosaDir = utils.getCosaDir(params);
Expand All @@ -31,6 +32,9 @@ def call(params = [:]) {
// the signatures for the metal images won't have been created yet.
try {
shwrap("cd ${cosaDir} && cosa kola testiso --inst-insecure ${extraArgs} --output-dir ${outputDir}/${id}")
if (!params['skipPxeAppendRootfs']) {
shwrap("cd ${cosaDir} && cosa kola testiso pxe* --pxe-append-rootfs ${extraArgs} --output-dir ${outputDir}/${id}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pxe*

I would pick one or two and not run them all in order to try to not add too much more time to our already really long runtime for testiso tests.

Copy link
Author

@nikita-dubrovskii nikita-dubrovskii Feb 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only up to 4 tests depending on arch. We can limit this amount by deny-listing let's say 4k tests, and i'd do it in pipeline repo, not here. Wdyt?

}
} finally {
shwrap("cd ${cosaDir} && cosa shell -- tar -C ${outputDir} -c --xz ${id} > ${env.WORKSPACE}/${id}-${token}.tar.xz || :")
archiveArtifacts allowEmptyArchive: true, artifacts: "${id}-${token}.tar.xz"
Expand Down