Update Courses for Winter and Spring 2023 #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 0. |
noschiff
changed the title
|
Visit the preview URL for this PR (updated for commit 9d5b5d1): https://cornelldti-courseplan-dev--pr727-sp23-course-data-0nj7g6fz.web.app (expires Sun, 20 Nov 2022 03:00:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
|
You know what... this should be a scheduled script LOL |
benjamin-shen
approved these changes
Oct 21, 2022
@benjamin-shen we should make a GitHub action that we can manually trigger once the course roster is released. this script is starting to take a while to run! of course, I'd like to try to avoid sending the entire (now) 7mb file to the client and create some API that could also fix #703 one day. |
benjamin-shen
added a commit
that referenced
this pull request
Oct 21, 2022
benjamin-shen
added a commit
that referenced
this pull request
Oct 21, 2022
noschiff
added a commit
that referenced
this pull request
Oct 26, 2022
noschiff
pushed a commit
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates our list of courses and requirements JSON with offerings from Winter 2023 and Spring 2023.
npm run courses-gennpm run req-genTest Plan
Verify that the site works and has updated course data. Check that a new course such as AEP 3100 can be added and that the bottom bar shows up with expected information for it.
Notes
Total Running Time for
courses-gen: 682096ms.