[easy] Fix requirements json from #727 #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 0. |
|
Visit the preview URL for this PR (updated for commit 2af7f6a): https://cornelldti-courseplan-dev--pr729-ben-fix-reqs-json-oxo8yd73.web.app (expires Sun, 20 Nov 2022 08:24:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
noschiff
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Thanks Ben! We should definitely look into running the checks on what the code will be after we've merged the PR. The only downside is that this could make it a little confusing to understand why a check failed since it'd be run on code not in the branch if the branch is behind master.
noschiff
pushed a commit
that referenced
this pull request
Oct 26, 2022
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the bad requirements json since #727 branched off an outdated source.
See the note in #628. Luckily it was easily caught since subsequent checks will fail (including when pushing to master). According to this comment, changing the job so it runs on PR instead of pulls might fix this issue.
Test Plan
CI/CD