Updates related to CRAN lightgbm #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!! |
|
The vignette is failing. We should probably not build it in the CI as it takes long and large amount of computation. |
|
@dfalbel Yeah I saw that, I can change that to not evaluate if you like? |
|
Yes! that would be awesome @tonyk7440 |
tonyk7440
added a commit
to tonyk7440/treesnip
that referenced
this pull request
Dec 28, 2020
Merge pull request curso-r#34 from tonyk7440/master
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
Since lightgbm is now on CRAN, I updated some files related to that.
Build now fails at the
parallel_processingvignette. Any ideas what needs to be changed there? Would be happy to fix in this PR or open another one for those