Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing up R CMD Check #35

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Fixing up R CMD Check #35

merged 4 commits into from
Jul 2, 2021

Conversation

tonyk7440
Copy link
Contributor

Following up on #34 to try to get this to build successfully but have hit a bit of a roadblock.

  1. Error from logs
E  Running 'testthat.R' [70s] (1m 9.8s)
   Running the tests in 'tests/testthat.R' failed.
   Complete output:
     > library(testthat)
     > library(treesnip)
     Loading required package: parsnip
     > test_check("treesnip")

which doesn't tell me much.

I then tried running devtools::test() next but my R session crashes each time.

image

I'm not sure if this is a 'my machine' issue, does this happen for others?

  1. Other than that, I've updated an arg to use sample_prop instead of sample_size so that an error doesn't get generated. I think sample_size should be substituted for sample_prop in general to avoid confusion, does anyone have an opinion on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants