Updated GTStructure to use pointers to items instead of value receivers #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs. (#1) This is a breaking change as the public method signatures and main type has been modified. - allows creation of the structure and flexible mutating it before actual printing - pointer receiver should be more efficient for large structures - added simple test + test resources
d6o
reviewed
Mar 20, 2018
gotree_test.go
Outdated
| ) | ||
|
|
||
| // TestFolderTree should test if reading a folder returns rendered structure as expected | ||
| func TestFolderTree(t *testing.T) { |
There was a problem hiding this comment.
I don't like the idea of keeping the testfiles in the project, we should Improve the ReadFolder to be mockable or remove this test for now.
There was a problem hiding this comment.
Sure no problem.
- removed test folder we should find a better solution for testing `ReadFolder` method - updated readme to reflect signature changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated GTStructure to use pointers to items instead of value receivers.
This is a breaking change as the public method signatures and main type has been modified.