Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.labeled_value #938

Closed
Tracked by #50
mofojed opened this issue Oct 15, 2024 · 1 comment · Fixed by #1029
Closed
Tracked by #50

ui.labeled_value #938

mofojed opened this issue Oct 15, 2024 · 1 comment · Fixed by #1029
Assignees

Comments

@mofojed
Copy link
Member

mofojed commented Oct 15, 2024

Spectrum docs: https://react-spectrum.adobe.com/react-spectrum/LabeledValue.html
Docs ticket: #869

@mofojed
Copy link
Member Author

mofojed commented Nov 19, 2024

For date formatting, I suggest we simply accept a Java date format string: https://docs.oracle.com/javase/10/docs/api/java/text/SimpleDateFormat.html
We need to be able to handle nanoseconds, which the Intl.DateTimeFormat JS library does not account for.
We'll need to convert the date object to a format the client can understand (similar to date_picker) but we'll need to ensure we keep the nanosecond bit (so probably mapping to DateWrapper).

So for the format_options argument, we will accept NumberFormatOptions (which we've defined as NumberFieldFormatOptions) and DateFormatOptions (which we could define as something like { date_format: DateFormatJavaString }, and DateFormatJavaString is just a str with some docs linking to the Java docs: https://docs.oracle.com/javase/10/docs/api/java/text/SimpleDateFormat.html

@dsmmcken does this sound reasonable?

mattrunyon pushed a commit to mattrunyon/deephaven-plugins that referenced this issue Feb 3, 2025
Closes deephaven#938 and Closes deephaven#869 and closes DH-18132.

**Additional Notes:**
- After conversation with @mofojed yesterday, I will be creating
separate PR to implement the ability to pass in dates and have date
formatting (given that it will require a fair share of logic)
- Have put up this PR in the interim so that docs and the other
functionality can be reviewed

---------

Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Eric Lin <[email protected]>
Co-authored-by: Eric Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants