Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui.labeled_value #1029

Merged
merged 21 commits into from
Jan 23, 2025
Merged

feat: ui.labeled_value #1029

merged 21 commits into from
Jan 23, 2025

Conversation

AkshatJawne
Copy link
Contributor

@AkshatJawne AkshatJawne commented Nov 20, 2024

Closes #938 and Closes #869 and closes DH-18132.

Additional Notes:

  • After conversation with @mofojed yesterday, I will be creating separate PR to implement the ability to pass in dates and have date formatting (given that it will require a fair share of logic)
  • Have put up this PR in the interim so that docs and the other functionality can be reviewed

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an e2e test as well

@AkshatJawne AkshatJawne requested a review from mofojed November 22, 2024 18:20
@AkshatJawne AkshatJawne requested a review from mofojed November 26, 2024 22:12
mofojed
mofojed previously approved these changes Nov 27, 2024
dsmmcken
dsmmcken previously approved these changes Nov 29, 2024
dsmmcken
dsmmcken previously approved these changes Dec 4, 2024
margaretkennedy
margaretkennedy previously approved these changes Dec 4, 2024
@AkshatJawne AkshatJawne dismissed stale reviews from margaretkennedy and dsmmcken via 3d0729c December 5, 2024 16:32
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just merge in the latest main, should have those snapshots updated already.

# Conflicts:
#	tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-chromium-linux.png
#	tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-firefox-linux.png
#	tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-webkit-linux.png
# Conflicts:
#	tests/ui.spec.ts-snapshots/UI-all-components-render-1-1-chromium-linux.png
@ericlln ericlln requested a review from mofojed January 21, 2025 21:28
mofojed
mofojed previously approved these changes Jan 22, 2025
@ericlln ericlln merged commit 8f278a7 into deephaven:main Jan 23, 2025
18 checks passed
mattrunyon pushed a commit to mattrunyon/deephaven-plugins that referenced this pull request Feb 3, 2025
Closes deephaven#938 and Closes deephaven#869 and closes DH-18132.

**Additional Notes:**
- After conversation with @mofojed yesterday, I will be creating
separate PR to implement the ability to pass in dates and have date
formatting (given that it will require a fair share of logic)
- Have put up this PR in the interim so that docs and the other
functionality can be reviewed

---------

Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Eric Lin <[email protected]>
Co-authored-by: Eric Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.labeled_value docs: ui.labeled_value
5 participants