feat: ui.labeled_value #1029
Merged
feat: ui.labeled_value #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
reviewed
Nov 25, 2024
mofojed
previously approved these changes
Nov 27, 2024
Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
Co-authored-by: margaretkennedy <[email protected]>
mofojed
approved these changes
Nov 29, 2024
dsmmcken
previously approved these changes
Nov 29, 2024
mofojed
requested changes
Nov 29, 2024
Co-authored-by: Mike Bender <[email protected]>
…eephaven-plugins into 938_labelled_value
dsmmcken
previously approved these changes
Dec 4, 2024
margaretkennedy
previously approved these changes
Dec 4, 2024
AkshatJawne
dismissed stale reviews from margaretkennedy and dsmmcken
via
3d0729c
mofojed
requested changes
Dec 6, 2024
tests/express.spec.ts-snapshots/Histogram-loads-1-webkit-linux.png
Outdated
Show resolved
Hide resolved
# Conflicts: # tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-chromium-linux.png # tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-firefox-linux.png # tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-webkit-linux.png
# Conflicts: # tests/ui.spec.ts-snapshots/UI-all-components-render-1-1-chromium-linux.png
mofojed
previously approved these changes
Jan 22, 2025
Co-authored-by: margaretkennedy <[email protected]>
margaretkennedy
approved these changes
Jan 23, 2025
mattrunyon
pushed a commit
to mattrunyon/deephaven-plugins
that referenced
this pull request
Feb 3, 2025
Closes deephaven#938 and Closes deephaven#869 and closes DH-18132. **Additional Notes:** - After conversation with @mofojed yesterday, I will be creating separate PR to implement the ability to pass in dates and have date formatting (given that it will require a fair share of logic) - Have put up this PR in the interim so that docs and the other functionality can be reviewed --------- Co-authored-by: margaretkennedy <[email protected]> Co-authored-by: Mike Bender <[email protected]> Co-authored-by: Eric Lin <[email protected]> Co-authored-by: Eric Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #938 and Closes #869 and closes DH-18132.
Additional Notes: