Notify on mention #4538
Merged
Notify on mention #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicodh
commented
Jan 23, 2025
- disable dependendant settings - switch order All profiles => Current profile - mark "disabled" switches with opacity: 0.4
nicodh
force-pushed
the
notify-on-mention
branch
from
009daf1 to
ec212d3
Compare
|
This closes #4461, right? |
WofWca
reviewed
Feb 1, 2025
WofWca
requested changes
Feb 1, 2025
WofWca
reviewed
Feb 1, 2025
WofWca
reviewed
Feb 1, 2025
WofWca
reviewed
Feb 3, 2025
WofWca
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
I tested (almost?) all the cases to see if they comply with the flowchart, and it seems they do.
I'm still not super happy with how many backend calls this introduced, so I hope we'll have all this stuff handled in core in the future. And this setting is disabled by default anyway.
The settings reorder makes sense to me. An input should not affect whether the inputs above it are disabled.
The "disabled" style change also seems good.
Please take a look at the last code suggestion, and let's merge!
Co-authored-by: WofWca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4589