Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade core to 1.155.2 #4589

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Upgrade core to 1.155.2 #4589

merged 1 commit into from
Feb 1, 2025

Conversation

nicodh
Copy link
Member

@nicodh nicodh commented Jan 31, 2025

No description provided.

@nicodh nicodh requested a review from WofWca January 31, 2025 14:16
@nicodh nicodh mentioned this pull request Jan 31, 2025
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question, and the commit should say 1.155.2. Otherwise it's just an upgrade.

@@ -6,6 +6,9 @@
- highlight the first unread message upon opening a chat #4525

### Changed
- Update `@deltachat/stdio-rpc-server` and `deltachat/jsonrpc-client` to `1.155.2`
- Deduplicate blob files in chat.rs, config.rs, and integration.rs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this non-breaking?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not, since the file extensions are kept. It just might be confuse if the name is wrong (for example when downloading an attachement from a message). But that is already the case and it will be addressed in #4498 before the next release.

@nicodh nicodh force-pushed the update-core-1.155.2 branch from 862677f to 7f8c1e2 Compare January 31, 2025 15:10
@nicodh
Copy link
Member Author

nicodh commented Jan 31, 2025

the commit should say 1.155.2

Changed it

@WofWca WofWca changed the title Upgrade core to 1.55.2 Upgrade core to 1.155.2 Jan 31, 2025
@nicodh nicodh merged commit 0192cee into main Feb 1, 2025
11 of 12 checks passed
@nicodh nicodh deleted the update-core-1.155.2 branch February 1, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants