Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Bun Ecosystem is Placed Under Javascript in Image Builds #11554

Closed
wants to merge 2 commits into from

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Feb 11, 2025

What are you trying to accomplish?

This PR ensures that the bun ecosystem is correctly placed under the javascript directory in the ecosystem image generation process.

Previously, bun was included in the main loop alongside other standalone ecosystems. However, bun is part of javascript and should be structured accordingly.

Key Changes:

  • Preserved the existing loop for other ecosystems (no modifications to the main structure).
  • Added a separate RUN command to create the bun directory under javascript (javascript/lib/dependabot/javascript/bun).
  • Ensured bun.rb is placed inside javascript/lib/dependabot/javascript/bun.rb instead of being treated as a separate top-level ecosystem.

What issues does this affect or fix?

This improves consistency in ecosystem organization and aligns bun with other package managers under javascript.

Anything you want to highlight for special attention from reviewers?

  • This change does not affect functionality, but ensures proper file structure for bun.
  • The new structure ensures better separation of concerns for package managers under javascript.

How will you know you've accomplished your goal?

  • The build process correctly places bun under javascript instead of treating it as a standalone ecosystem.
  • The structure follows the intended ecosystem hierarchy.
  • No functionality changes, ensuring no impact on runtime behavior.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 force-pushed the kamil/fix-bun-issues branch from 28109fd to 488a8f0 Compare February 11, 2025 20:23
@kbukum1 kbukum1 marked this pull request as ready for review February 11, 2025 20:23
@kbukum1 kbukum1 requested a review from a team as a code owner February 11, 2025 20:23
@kbukum1
Copy link
Contributor Author

kbukum1 commented Feb 11, 2025

Duplicate: #11555

@kbukum1 kbukum1 closed this Feb 11, 2025
@kbukum1 kbukum1 self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants