-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dependabot-common
gem if available
#11555
Merged
markhallen
merged 8 commits into
main
from
markhallen/use-dependabot-common-if-available
Feb 12, 2025
Merged
Use dependabot-common
gem if available
#11555
markhallen
merged 8 commits into
main
from
markhallen/use-dependabot-common-if-available
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robaiken
previously approved these changes
Feb 11, 2025
kbukum1
previously approved these changes
Feb 11, 2025
5 tasks
robaiken
previously approved these changes
Feb 11, 2025
kbukum1
previously approved these changes
Feb 11, 2025
Hang on, are we sure we even need to support the |
b62a7fa
to
c69b13d
Compare
robaiken
approved these changes
Feb 12, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We should try to load the
common/lib
path and fallback to the gem. This should cover running in the dry-run, api and nowdependabot-omnibus
gem.The files could not be located when running in the
dependabot-omnibus
gem.Anything you want to highlight for special attention from reviewers?
Ideally we could test building the
dependabot-omnibus
gem without going through the whole release process.How will you know you've accomplished your goal?
dependabot-omnibus
should build successfully.Checklist