Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Flag] - Remove enable_fix_for_pnpm_no_change_error Feature Flag #11592

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Feb 13, 2025

What are you trying to accomplish?

This change removes the enable_fix_for_pnpm_no_change_error feature flag from dependabot-core and dependabot-api, making the logic always behave as if the flag were enabled. This simplifies the code and ensures the fix is always applied.

What issues does this affect or fix?

The feature flag is no longer needed as the fix is stable, and removing it helps streamline the codebase.

Anything you want to highlight for special attention from reviewers?

  • The removal of the feature flag is straightforward, but please review to ensure no unintended dependencies remain.
  • All conditional checks for this flag have been removed or modified to assume it is always true.

How will you know you've accomplished your goal?

  • All related tests should pass without issues.
  • The expected behavior (previously gated by the feature flag) should now be the default behavior.
  • Code should be simpler and easier to maintain without feature flag conditionals.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

dependency_set
end

def dependencies_with_prioritization
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Tip: We were using dependencies_with_prioritization as dependencies method when enable_fix_for_pnpm_no_change_error was enabled.

@kbukum1 kbukum1 marked this pull request as ready for review February 13, 2025 20:28
@kbukum1 kbukum1 requested a review from a team as a code owner February 13, 2025 20:28
@kbukum1 kbukum1 merged commit af9b86e into main Feb 13, 2025
69 of 70 checks passed
@kbukum1 kbukum1 deleted the kamil/remove_ff_enable_fix_for_pnpm_no_change_error branch February 13, 2025 20:54
@kbukum1 kbukum1 self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants