Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Smoke Tests to Reflect Default Behavior After Feature Flag Removal #258

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Feb 13, 2025

Summary of Changes

This PR updates the smoke tests to align with the behavior after the removal of the enable_fix_for_pnpm_no_change_error feature flag.

Although the feature flag had been enabled for the past two weeks, the smoke tests were still running without it. Now that the feature flag has been removed, the previously gated logic is the default behavior, and the smoke tests are now executing this code for the first time. As a result, adjustments were required to adapt the smoke tests to the new expected outputs.

Related PRs:

Why This Change?

  • The enable_fix_for_pnpm_no_change_error feature flag was removed from dependabot-core and dependabot-api, making its logic the new default.
  • Smoke tests were not previously running with this flag enabled, meaning they are now interacting with this code for the first time.
  • Updates were needed to ensure that the test expectations reflect the new behavior.

Key Updates

  • Modified test expectations to match the now-default behavior that was previously behind the feature flag.
  • Verified that all test cases align with the latest Dependabot behavior without requiring feature flag conditionals.

Validation & Testing

  • Smoke tests now pass with the updated expectations.
  • Confirmed that the changes align with the behavior enforced by the recent feature flag removal.
  • No unintended test failures or discrepancies in recorded outputs.

@kbukum1 kbukum1 requested a review from a team as a code owner February 13, 2025 22:04
@kbukum1 kbukum1 enabled auto-merge February 13, 2025 22:30
@kbukum1 kbukum1 merged commit 1bfc7d5 into main Feb 13, 2025
77 of 79 checks passed
@kbukum1 kbukum1 deleted the kamil/fix-smoke-test-after-ff-clean-up branch February 13, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants