mount the SSH_AUTH_SOCK socket for ssh-agent #11683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
L: elixir:hex
dmitris
force-pushed
the
ssh-in-docker-images
branch
3 times, most recently
from
fe0a742 to
328da8a
Compare
6 tasks
dmitris
force-pushed
the
ssh-in-docker-images
branch
4 times, most recently
from
35f3aef to
e38d4c1
Compare
dmitris
force-pushed
the
ssh-in-docker-images
branch
11 times, most recently
from
0e2416b to
02e345d
Compare
dmitris
force-pushed
the
ssh-in-docker-images
branch
2 times, most recently
from
e213546 to
9c18df0
Compare
Mount the SSH_AUTH_SOCK into the docker-dev-shell container
to propagate the SSH agent credentials and allow git access
to servers/repositories which require the ssh credentials.
The added volume mapping in 'docker run' applies only if
${SSH_AUTH_SOCK} is not empty.
For Mac with Docker or Rancher Desktop, the following
value can be used:
SSH_AUTH_SOCK=/run/host-services/ssh-auth.sock \
./bin/docker-dev-shell go_modules -r
Issue dependabot#11544 - addresses the second checkbox:
ssh-add -l shows the same ssh keys as in the "outside" user session.
Signed-off-by: Dmitry Savintsev <[email protected]>
dmitris
force-pushed
the
ssh-in-docker-images
branch
from
a0998db to
a89ba31
Compare
sachin-sandhu
approved these changes
Mar 13, 2025
thavaahariharangit
approved these changes
Mar 13, 2025
thavaahariharangit
added a commit
that referenced
this pull request
Mar 14, 2025
This reverts commit e14ac74.
thavaahariharangit
added a commit
that referenced
this pull request
Mar 15, 2025
This reverts commit e14ac74. Co-authored-by: kbukum1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
PR is part of the "plan" in #11544 - addressing its second checkbox:
ssh-add -lshows the same ssh keys as in the "outside" user sessionIt allows to run
bin/docker-dev-shelland propagate your host SSH credentials. The end goal is to be able to run the tests and dependabot actions that require SSH credentials for access to the code repositories.Anything you want to highlight for special attention from reviewers?
I wonder if I should add a flag to activate propagation of the ssh credentials (so that you wouldn't have anything changed compared to the status quo without the flag)?
How will you know you've accomplished your goal?
SSH_AUTH_SOCKset (or if we use the flag, who don't pass the flag to propagate their ssh credentials)ssh-add -linside the container shows the same keys as in the "outer" hostChecklist