Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "mount the SSH_AUTH_SOCK socket for ssh-agent" #11818

Merged
merged 3 commits into from
Mar 15, 2025

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Mar 14, 2025

Reverts #11683

As @robaiken has raised an issue with this config.

docker: Error response from daemon: error while creating mount source path '/host_mnt/private/tmp/com.apple.launchd.Q3NRTvcke4/Listeners': mkdir /host_mnt/private/tmp/com.apple.launchd.Q3NRTvcke4/Listeners: operation not supported```

@dmitris Need your thoughts on this pls

FYI @abdulapopoola

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner March 14, 2025 18:09
@thavaahariharangit thavaahariharangit merged commit 83187c8 into main Mar 15, 2025
62 checks passed
@thavaahariharangit thavaahariharangit deleted the revert-11683-ssh-in-docker-images branch March 15, 2025 22:20
@dmitris
Copy link
Contributor

dmitris commented Mar 16, 2025

I asked in #11683 ("Anything you want to highlight for special attention from reviewers?"):

I wonder if I should add a flag to activate propagation of the ssh credentials (so that you wouldn't have anything changed compared to the status quo without the flag)?

I would suggest we put the ssh credentials propagation under the flag (such as --ssh-agent), so that it could be used by those who need it, but otherwise it would not change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants