Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: checkstyle unused imports rule #1011

Merged

Conversation

algattik
Copy link
Contributor

What this PR changes/adds

Add a rule to fail build on unused imports.

Why it does that

Remove unnecessary coupling and dependencies, and reduce PR diffs.

Further notes

Linked Issue(s)

Relates to #991

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@algattik algattik marked this pull request as ready for review March 30, 2022 11:17
@algattik algattik marked this pull request as draft April 1, 2022 07:40
@cpeeyush cpeeyush assigned cpeeyush and unassigned cpeeyush Apr 7, 2022
@algattik algattik force-pushed the feature/991-checkstyle-unused-import branch from ce65b39 to d9610d6 Compare April 13, 2022 05:40
@codecov-commenter
Copy link

Codecov Report

Merging #1011 (050e088) into main (2a1db74) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1011   +/-   ##
=========================================
  Coverage     62.61%   62.61%           
  Complexity     2969     2969           
=========================================
  Files           694      694           
  Lines         15416    15416           
  Branches       1044     1044           
=========================================
  Hits           9652     9652           
  Misses         5334     5334           
  Partials        430      430           
Impacted Files Coverage Δ
.../dataspaceconnector/common/string/StringUtils.java 83.33% <ø> (ø)
...paceconnector/boot/system/runtime/BaseRuntime.java 0.00% <ø> (ø)
...pi/multipart/handler/ContractAgreementHandler.java 0.00% <ø> (ø)
...ds/api/multipart/handler/ContractOfferHandler.java 0.00% <ø> (ø)
...pi/multipart/handler/ContractRejectionHandler.java 0.00% <ø> (ø)
.../ids/api/multipart/handler/DescriptionHandler.java 46.80% <ø> (ø)
.../multipart/handler/NotificationMessageHandler.java 93.75% <ø> (ø)
...description/ArtifactDescriptionRequestHandler.java 0.00% <ø> (ø)
...cription/DataCatalogDescriptionRequestHandler.java 0.00% <ø> (ø)
...ption/RepresentationDescriptionRequestHandler.java 100.00% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98038f7...050e088. Read the comment docs.

@algattik algattik force-pushed the feature/991-checkstyle-unused-import branch 4 times, most recently from e7495d5 to 881e493 Compare April 14, 2022 13:10
@algattik algattik marked this pull request as ready for review April 14, 2022 14:54
@algattik algattik force-pushed the feature/991-checkstyle-unused-import branch from 881e493 to 32300b2 Compare April 21, 2022 10:15
@algattik algattik requested a review from bscholtes1A as a code owner April 21, 2022 10:15
@bscholtes1A bscholtes1A merged commit 129ad29 into eclipse-edc:main Apr 21, 2022
@algattik algattik deleted the feature/991-checkstyle-unused-import branch June 22, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants