Enable additional checkstyle checks

[algattik]

Feature Request

Which Areas Would Be Affected?

All

Why Is the Feature Desired?

Improve code consistency and reduce spurious PR diffs by enabling additional checkstyle checks as applicable.

Solution Proposal

• Evaluate additional checks, e.g. from list below
• Consider whether upgrading to checkstyle 10 brings benefits
• Ensure any checks that generate many violations in existing codebase don't break the build initially, they can be tightened later

Examples of checks that could be added:

• Header
• NewlineAtEndOfFile
• SuppressWarningsFilter (not a check, but allows disabling checks in specific files)
• the following checks are used in Azure SDK but not currently enabled in EDC:
  • AvoidNestedBlocks
  • ConstantNameCheck
  • EmptyForIteratorPad
  • EmptyStatement
  • EqualsHashCode
  • FinalClass
  • IllegalImport
  • IllegalInstantiation
  • InnerAssignment
  • InterfaceIsType
  • LocalFinalVariableName
  • MagicNumber
  • MemberNameCheck
  • MethodNameCheck
  • MissingDeprecated
  • MissingJavadocPackage
  • NoWhitespaceAfter
  • RedundantImport
  • RedundantModifier
  • StaticVariableName
  • StaticVariableNameCheck
  • TypeNameCheck
  • TypecastParenPad
  • UnusedImports
  • VisibilityModifier
  • SuppressWarningsHolder

Type of Issue

code quality improvement

Checklist

• assigned appropriate label?
• Do NOT select a milestone or an assignee!

[github-actions]

This issue is stale because it has been open for 28 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 7 days since being marked as stale.