Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add checkstyle rule for MissingDeprecated #1167

Conversation

algattik
Copy link
Contributor

What this PR changes/adds

Add a rule for checkstyle check MissingDeprecated.

Verifies that the annotation @deprecated and the Javadoc tag @deprecated are both present when either of them is present.

Why it does that

Improve code consistency and reduce spurious PR diffs.

Further notes

Linked Issue(s)

Relates to #991

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

Codecov Report

Merging #1167 (c2e118f) into main (045c9a6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1167   +/-   ##
=========================================
  Coverage     62.65%   62.65%           
  Complexity     2981     2981           
=========================================
  Files           694      694           
  Lines         15428    15428           
  Branches       1048     1048           
=========================================
  Hits           9666     9666           
  Misses         5331     5331           
  Partials        431      431           
Impacted Files Coverage Δ
...pi/control/response/NegotiationStatusResponse.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045c9a6...c2e118f. Read the comment docs.

@algattik algattik marked this pull request as ready for review April 19, 2022 08:42
@bscholtes1A bscholtes1A merged commit bf060bd into eclipse-edc:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants